New issue
Advanced search Search tips

Issue 732063 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

systemLanguage chokes on commas; Interface SVGTests

Reported by glroyla...@gmail.com, Jun 10 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36

Steps to reproduce the problem:
1. load attached file and look at console log
2. 
3. 

What is the expected behavior?
For Accept-Languages: en brower, the first text element of the SVG file should display; in Chrome, the default 3rd line displays.

The .systemLanguage SVGStringList should have exactly 3 items and none of those items should have commas. Chrome treats the comma separator as a character.

What went wrong?
Chrome fails to follow the SVG specification for systemLanguage attribute. The attribute is a COMMA-separated list of langtags (with optional spaces). Chrome parses the attribute as a SPACE-separated list (like the class attribute).

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 59.0.3071.86  Channel: stable
OS Version: 10.0
Flash Version: 

This is the fourth time I've tried to post this bug. The last two times, Chrome just hung.
 
ChromeSysLangBug.html
3.7 KB View Download

Comment 1 by f...@opera.com, Jun 10 2017

Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac
Status: Available (was: Unconfirmed)
Labels: -OS-Fuchsia
Here's a jsFiddle:

https://jsfiddle.net/8z06cfx2/21/


Project Member

Comment 4 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27

commit be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27
Author: sudo45 <luca94dd@gmail.com>
Date: Thu Sep 06 16:39:29 2018

Parse 'systemLanguage' as a comma separated list

Now Chrome parses the systemLanguage attribute as a COMMA separated-
list (with optional space), following the SVG specification
for systemLanguage attribute.

The previous behavior was:

- The systemLanguage attribute is a space-separated list
of langtags (the comma separator was treated as a character).

Example:

<text systemLanguage="en-US, zh-Hans,zh-Hant"></text>

Now, the three langtags are: "en-US", "zh-Hans", "zh-Hant".
Before, the three langtags were "en-US,", "zh-Hans,", "zh-Hant".

R=fs@opera.com, schenney@chromium.org

Bug:  732063 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7738bc4eb77de2c1ca7593dd9277fab14d39cc1f
Reviewed-on: https://chromium-review.googlesource.com/1207250
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589189}
[add] https://crrev.com/be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27/third_party/WebKit/LayoutTests/svg/dom/systemLanguage-comma-separated.html
[modify] https://crrev.com/be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27/third_party/blink/renderer/core/svg/svg_static_string_list.cc
[modify] https://crrev.com/be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27/third_party/blink/renderer/core/svg/svg_static_string_list.h
[modify] https://crrev.com/be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27/third_party/blink/renderer/core/svg/svg_string_list.cc
[modify] https://crrev.com/be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27/third_party/blink/renderer/core/svg/svg_string_list.h
[modify] https://crrev.com/be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27/third_party/blink/renderer/core/svg/svg_string_list_tear_off.cc
[modify] https://crrev.com/be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27/third_party/blink/renderer/core/svg/svg_string_list_tear_off.h
[modify] https://crrev.com/be92af090cae7b5f69f8cc33cbe0a4e9c5f37e27/third_party/blink/renderer/core/svg/svg_tests.cc

Status: Fixed (was: Available)

Sign in to add a comment