Issue metadata
Sign in to add a comment
|
[Canary] bookmarks bar icons are cut off
Reported by
wolfw...@gmail.com,
Jun 10 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3124.10 Safari/537.36 Steps to reproduce the problem: In Canary, bookmarks bar icons are cut off by 1px at the bottom. They are actually positioned 1px lover than usual, and because of that bottom is cut off What is the expected behavior? What went wrong? - Did this work before? N/A Chrome version: 61.0.3124.10 Channel: dev OS Version: 10.0 Flash Version:
,
Jun 10 2017
*loWer :)
,
Jun 12 2017
,
Jun 12 2017
Able to reproduce this issue on Windows 10 with chrome Stable #59.0.3071.86 and also in canary #61.0.3127.0 Issue broken in M61 Bisect Info: =========== Good build : 61.0.3117.0 , Revision Range - 476123 Bad build : 61.0.3119.0 , Revision Range - 476838 After executing the per-revision bisect script, i got the following CL's between good and bad build versions =========================================== https://chromium.googlesource.com/chromium/src/+log/9939f3a8acf8565958bfc50d01ff7c0f7bd4ebe5..7073ae5bc6af913c649500e015210992f9c7111a The suspecting Change Log is : ----------- Review-Url: https://codereview.chromium.org/2899133004 yiyix@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner. Note: Issue not reproducible in Mac 10.12.5 and Ubuntu 14.04
,
Jun 12 2017
*** Corrections in Comment #4 *** Issue is only reproducible on Dev #61.0.3124.10 and Canary #61.0.3127.0 but not on Stable #59.0.3071.86 and Beta #60.0.3112.24
,
Jun 12 2017
Issue 730570 has been merged into this issue.
,
Jun 12 2017
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f4c74729badb56a8a0d4c4cd18fea329f9fa552 commit 2f4c74729badb56a8a0d4c4cd18fea329f9fa552 Author: yiyix <yiyix@chromium.org> Date: Wed Jun 14 20:09:57 2017 Fix: Icons are chopped from bottom on bookmark bar In cl "reducing overdraw on bookmark bar", https://codereview.chromium.org/2899133004, the height of bookmark bar is reduced by 1 px for both detached mode and attached mode after removing the 1 px overlap between toolbar and bookmark bar. However, the tool bar and bookmark bar only overlaps when bookmark bar is in detached mode. The height of bookmark bar in attached mode should remain unchanged. TEST=BrowserView.BrowserViewLayout Bug: 732062 Change-Id: Id363f9cf9d3ef5a606eb3f94723b28c5b1db09cb Reviewed-on: https://chromium-review.googlesource.com/532055 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#479482} [modify] https://crrev.com/2f4c74729badb56a8a0d4c4cd18fea329f9fa552/chrome/browser/ui/bookmarks/bookmark_bar_constants.h [modify] https://crrev.com/2f4c74729badb56a8a0d4c4cd18fea329f9fa552/chrome/browser/ui/views/frame/browser_view_unittest.cc
,
Jun 19 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by wolfw...@gmail.com
, Jun 10 2017