New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732020 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Undefined-shift in normalize_t_s

Project Member Reported by ClusterFuzz, Jun 10 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5820835683368960

Fuzzer: libFuzzer_skia_pathop_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  normalize_t_s
  classify_cubic
  SkClassifyCubic
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=478353:478423

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5820835683368960


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org
Components: Internals>Skia
Labels: M-61 Test-Predator-Correct-CLs
Owner: csmartdalton@chromium.org
Status: Assigned (was: Untriaged)
Assigning to concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: Chris Dalton
Project: chromium-skia
Changelist: https://skia.googlesource.com/skia.git/+/febbffad1c24136f041d7fc2d5ffcd50e47a047f
Time: Thu Jun 08 13:12:02 2017 -0600
Lines 251-257, 266 of file SkPathOpsCubic.cpp which potentially caused crash are changed in this cl (frame #3, "SkDCubic::ComplexBreak"). 

Lines 574-603, 636-653, 665-668 of file SkGeometry.cpp which potentially caused crash are changed in this cl (frame #0, "normalize_t_s"; frame #1, "classify_cubic"; frame #2, "SkClassifyCubic").
Minimum distance from crash line to modified line: 0. (file: SkPathOpsCubic.cpp, crashed on: 257, modified: 257).

@Chris Dalton -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 12 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "csmartdalton@chromium.org" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I am able to receive emails and these messages reached my inbox. I wonder why they thought it was bouncing?
Is someone able to help me understand what the fuzzer doesn't like this shift?

https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkGeometry.cpp?type=cs&q=normalize_t_s+package:%5Echromium$&l=570
Project Member

Comment 5 by ClusterFuzz, Jun 13 2017

ClusterFuzz has detected this issue as fixed in range 478714:478793.

Detailed report: https://clusterfuzz.com/testcase?key=5820835683368960

Fuzzer: libFuzzer_skia_pathop_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  normalize_t_s
  classify_cubic
  SkClassifyCubic
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=478353:478423
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=478714:478793

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5820835683368960


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jun 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 5820835683368960 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment