(the CQ didn't update this bug)
We need to backmerge to M59 and M60 this CL. It unblocks chromium:723899

https://chromium-review.googlesource.com/c/530193/

The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Switching to "Started" until we back-merge.

This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please specify impacted OS's. Since we are already rolling out M59 Stable (at 5% currently), why is this change critical to be considered for M59 merge? Is there any specific user impact? Seems like it has been present in M58. Please explain the urgency for this change.

Please see #1: chromium:723899 is blocked by this issue. A partial fix for that bug has been back-merged in 59 and 60. This issue here addresses the remaining of the problem.

Should I tag the change off that other bug?

As discussed over chat, this change has not been fully tested in canary yet. Since M59 stable is already out and bar is very high for merges, I'm rejecting merge for M59. 

Please confirm when this has been tested in canary, and we can re-review merge for M60. 

mtrofin@ - can you confirm if you were able to test this in Canary/Dev and how does it look there?

It uncovered one more OOM problem, which I'm in the process of addressing. My plan is to tag that one with this issue ID, re-verify in canary, and get back on this thread, if that sounds reasonable?

Thanks!

sounds good - thanks!

I'm marking this as merge-60-rejected for now (so it disappears from our review queue). Please re-request when you're ready. 

re comment#10, https://chromium-review.googlesource.com/c/540763/ landed (unfortunately, didn't get linked here, looks like gerrit won't do that for a second bug reference)

I'll wait a day or two for this change to go through canary, validate, then re-apply the merge request label, as discussed.

Validated canary windows 32 bit, all works well.

Re-applying merge request - note I'm applying it for:

https://chromium-review.googlesource.com/c/530193/

- and -

https://chromium-review.googlesource.com/c/540763/

Please let me know if I need to attach the merge request separately

This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Based on comments 14, approving merge to M60. 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This was merged in https://chromium.googlesource.com/v8/v8/+/f9e1999ebce1cf71a273984da31e57e660e38bd5.

We don't appear to have a M60 build with it at the moment, I'll chime back here once we do, to get confirmation from Epic.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot