Xcode 9 chrome egtest integration doesn't find any tests |
|||
Issue description./out/Debug-iphonesimulator/iossim out/Debug-iphonesimulator/ios_chrome_integration_egtests.app/ out/Debug-iphonesimulator/ios_chrome_integration_egtests.app/PlugIns/ios_chrome_integration_egtests_module.xctest/ Test Suite 'Selected tests' passed at 2017-06-09 22:14:50.267. Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.002) seconds ** TEST EXECUTE SUCCEEDED **
,
Jun 12 2017
Xcode seems to run our tests fine, presumably there's something wrong with iossim's wrapping of the xcodebuild test cmd line.
,
Jun 13 2017
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d40236c61af27c3a50474415203c9ac26e2d725e commit d40236c61af27c3a50474415203c9ac26e2d725e Author: Yuke Liao <liaoyuke@chromium.org> Date: Wed Jun 14 18:36:02 2017 Fix an "only testing tests" bug in iossim. In iossim.mm, following code is buggy: if (only_testing_tests) { [testTargetName setObject:only_testing_tests forKey:@"OnlyTestIdentifiers"]; } because only_testing_tests is an initialized NSMutableArray, which will always be evaluated to true, so changing the condition to: if ([only_testing_tests count] > 0) Bug: 732007 Change-Id: I48014956c971fdf744ff38cf3975008f40061133 Reviewed-on: https://chromium-review.googlesource.com/534944 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#479452} [modify] https://crrev.com/d40236c61af27c3a50474415203c9ac26e2d725e/testing/iossim/iossim.mm
,
Jun 14 2017
Fixed, this is caused by a bug in iossim.mm, please refer to the CL for details. |
|||
►
Sign in to add a comment |
|||
Comment 1 by liaoyuke@chromium.org
, Jun 12 2017