New issue
Advanced search Search tips

Issue 731948 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

auto-select-desktop-capture-source flag ends up selecting entire screen even though it detected a specific window

Reported by jeff.sh...@highfive.com, Jun 9 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce the problem:
1.  find chrome directory and type ./chrome --auto-select-desktop-capture-source='name of some window' 
2. Open two tabs and enter https://meet.jit.si/testme in both windows
3. In one of the windows click screenshare button (accept the extensions)

What is the expected behavior?
Without having to pick the screenshare source, it shares the window you had specified before you launched chrome.

What went wrong?
Your entire screen gets shared.

Did this work before? N/A 

Chrome version: 58.0.3029.110  Channel: stable
OS Version: 
Flash Version: 

This works on windows and osx, seems to only be an issue on linux.
 
OS Version: Ubuntu 17.04
Labels: Needs-Milestone
Components: -Platform>DevTools Blink>WebRTC

Comment 4 by guidou@chromium.org, Jun 20 2017

Components: -Blink>WebRTC Blink>GetUserMedia>Desktop
Cc: niklase@chromium.org
Owner: qiangchen@chromium.org
Status: Assigned (was: Unconfirmed)
Qiang, I wonder if this could be an effect of the new picker, since it works if you only have 'window' as constraint to chooseDesktopMedia. I did some debugging and it looks like we get a hit for the window name (I use 'Terminal' for testing), but we end up sharing the desktop instead. Please not that this flag is only used for testing.
Re#5: Right, this is a bug for new picker.
At [1], we try to move focus onto the source to be selected, and then click share button using c++ code at [2]. 

Now the issue is that if the picker shows screen and window, window tab is not in the front, and thus [1] does not work. Then we still click share button at [2], which will result in sharing the desktop.

I'll figure a solution out. 

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc?l=206

[2] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc?l=207
Status: Fixed (was: Assigned)
Fixed in https://chromium-review.googlesource.com/c/556305/

Sign in to add a comment