Wait to destroy BottomSheetContent until sheet content transition is finished |
||||
Issue descriptionCurrently we destroy BottomSheetContent objects as soon as the sheet is closed. We should wait until the sheet content transitions are finished to avoid destroying something that is technically still in use. In issue 731093 I worked around a symptom of this. I suspect that reverting the (very small) changes in https://chromium-review.googlesource.com/530090 and changing the destruction policy would also have fixed the crash in that bug.
,
Jun 23 2017
,
Jul 11 2017
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4f70af6616619e994d16b67f4fae8cc4ea2f155 commit a4f70af6616619e994d16b67f4fae8cc4ea2f155 Author: danielpark@chromium.org <danielpark@chromium.org> Date: Tue Jul 11 22:31:20 2017 Deleting BottomSheetContent at a later time Changed timing of BottomSheetContent destruction to occur when the contents are no longer in use i.e. the bottom sheet is set to home and is closed or after the sheet is closed and the content switch from bookmarks, history, or downloads to home has happened. Bug: 731940 Change-Id: I791574b80efaffece8403fe9b119f27292a078f5 Reviewed-on: https://chromium-review.googlesource.com/566059 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#485700} [modify] https://crrev.com/a4f70af6616619e994d16b67f4fae8cc4ea2f155/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
,
Jul 12 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by twelling...@chromium.org
, Jun 23 2017Status: Assigned (was: Available)