New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Delete second list item inside a single table cell should not delete the whole table

Project Member Reported by jfernan...@igalia.com, Jun 9 2017

Issue description

Chrome Version: 60.0.3095.5
OS: Linux

What steps will reproduce the problem?
(1) Load the attached test case
(2) Place the cursor at the list item 2.
(3) Hit backspace to the list item is removed

What is the expected result?

The list item 2 is removed but the list still holds the item 1.

What happens instead?

The whole table is deleted.

 
deleteSecondLiDeletesTable.html
251 bytes View Download

Comment 2 by yosin@chromium.org, Jun 12 2017

Cc: -yosin@chromium.org
Components: -Blink>Editing>Content Blink>Editing>Command
Status: Available (was: Untriaged)
Copy the test case into: https://jsfiddle.net/9m34ohgd/
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5961ff06240e30a18405608f06d8eea4730c7b8f

commit 5961ff06240e30a18405608f06d8eea4730c7b8f
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Tue Feb 20 05:42:19 2018

Delete list item inside table deletes table.

Inside a table, if there are two empty
list items, deleting the second list
deletes the entire table.

In an empty list the deep equivalent for
first position and its next position comes
as same.

I think that FirstInSpecialElement was
for the hidden elements like span, br etc,
therefore this CL do not consider
list element for a special element category.

Bug:  731913 
Change-Id: I03a6ec7559a5271954c85561d9c27db75a921452
Reviewed-on: https://chromium-review.googlesource.com/921301
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#537723}
[add] https://crrev.com/5961ff06240e30a18405608f06d8eea4730c7b8f/third_party/WebKit/LayoutTests/editing/deleting/delete_only_secondlast_item.html
[modify] https://crrev.com/5961ff06240e30a18405608f06d8eea4730c7b8f/third_party/WebKit/Source/core/editing/commands/EditingCommandsUtilities.cpp

Owner: jfernan...@igalia.com
Status: Fixed (was: Available)
Thanks for the patch. This issue seems to be FIXED now.
We still need to decide what to do with issues like #731320 and #731000

Sign in to add a comment