New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731892 link

Starred by 4 users
Status: Archived
Owner:
newcomer@chromium.org
Closed: Jun 2017
Cc:
█ vadimt@chromium.org
xiy...@chromium.org
sky@chromium.org
Components:
EstimatedDays: 3
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Add Half AppList to new AppList UI

Project Member Reported by newcomer@chromium.org, Jun 9 2017 
Add the Half AppList, which is an intermediate state between peeking app list and fullscreen app list.

In tablet mode only the fullscreen state is valid.
In laptop mode, half, peeking, and fullscreen are valid states.

All functionality is hidden behind the EnableFullscreenAppList feature flag.

Comment 1 by newcomer@chromium.org, Jun 9 2017

Labels: -Type-Bug Type-Feature

Comment 2 by newcomer@chromium.org, Jun 13 2017

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7

commit a1201ceb12bfedf51cb1c0e01879bd3521ba88a7
Author: newcomer <newcomer@chromium.org>
Date: Thu Jun 15 21:50:31 2017

Added HALF, FULLSCREEN_ALL_APPS, and FULLSCREEN_SEARCH.

|HALF| - Half App List. This mode is
entered when the user types into the search box from
peeking mode.

|FULLSCREEN_ALL_APPS| - Fullscreen app list that
shows all apps. Entered by default in maximize and
side shelf modes. Also entered with an upward swipe
from |PEEKING|.

|FULLSCREEN_SEARCH| -  Fullscreen app list that
shows search results. Entered from
FULLSCREEN_ALL_APPS after text is entered in the
search box, or from upward swipe from |HALF|.

Please note: all Mash support will come post 61 as
per  crbug.com/726838 

BUG= 731892 

Review-Url: https://codereview.chromium.org/2939693004
Cr-Commit-Position: refs/heads/master@{#479851}

[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ui/app_list/demo/app_list_demo_views.cc
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ui/app_list/presenter/app_list_presenter_impl_unittest.cc
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ui/app_list/views/all_apps_tile_item_view.cc
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7/ui/app_list/views/search_box_view.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59

commit cfa2b1f18a8c741f8e285d818fbcaed3c6595c59
Author: findit-for-me <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Jun 16 00:06:23 2017

Revert of Added HALF, FULLSCREEN_ALL_APPS, and FULLSCREEN_SEARCH. (patchset #8 id:330001 of https://codereview.chromium.org/2939693004/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 479851 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ExMjAxY2ViMTJiZmVkZjUxY2IxYzBlMDE4NzliZDM1MjFiYTg4YTcM

Original issue's description:
> Added HALF, FULLSCREEN_ALL_APPS, and FULLSCREEN_SEARCH.
>
> |HALF| - Half App List. This mode is
> entered when the user types into the search box from
> peeking mode.
>
> |FULLSCREEN_ALL_APPS| - Fullscreen app list that
> shows all apps. Entered by default in maximize and
> side shelf modes. Also entered with an upward swipe
> from |PEEKING|.
>
> |FULLSCREEN_SEARCH| -  Fullscreen app list that
> shows search results. Entered from
> FULLSCREEN_ALL_APPS after text is entered in the
> search box, or from upward swipe from |HALF|.
>
> Please note: all Mash support will come post 61 as
> per  crbug.com/726838 
>
> BUG= 731892 
>
> Review-Url: https://codereview.chromium.org/2939693004
> Cr-Commit-Position: refs/heads/master@{#479851}
> Committed: https://chromium.googlesource.com/chromium/src/+/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7

TBR=vadimt@chromium.org,xiyuan@chromium.org,oshima@chromium.org,newcomer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 731892 

Review-Url: https://codereview.chromium.org/2938203004
Cr-Commit-Position: refs/heads/master@{#479883}

[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ui/app_list/demo/app_list_demo_views.cc
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ui/app_list/presenter/app_list_presenter_impl_unittest.cc
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ui/app_list/views/all_apps_tile_item_view.cc
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59/ui/app_list/views/search_box_view.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f486598b282e1f5399b94b04ca25e7e3bbd12526

commit f486598b282e1f5399b94b04ca25e7e3bbd12526
Author: newcomer <newcomer@chromium.org>
Date: Fri Jun 16 16:19:32 2017

Added HALF, FULLSCREEN_ALL_APPS, and FULLSCREEN_SEARCH.

|HALF| - Half App List. This mode is
entered when the user types into the search box from
peeking mode.

|FULLSCREEN_ALL_APPS| - Fullscreen app list that
shows all apps. Entered by default in maximize and
side shelf modes. Also entered with an upward swipe
from |PEEKING|.

|FULLSCREEN_SEARCH| -  Fullscreen app list that
shows search results. Entered from
FULLSCREEN_ALL_APPS after text is entered in the
search box, or from upward swipe from |HALF|.

Please note: all Mash support will come post 61 as
per  crbug.com/726838 

BUG= 731892 

Review-Url: https://codereview.chromium.org/2939693004
Cr-Original-Commit-Position: refs/heads/master@{#479851}
Committed: https://chromium.googlesource.com/chromium/src/+/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7
Review-Url: https://codereview.chromium.org/2939693004
Cr-Commit-Position: refs/heads/master@{#480064}

[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ui/app_list/demo/app_list_demo_views.cc
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ui/app_list/presenter/app_list_presenter_impl_unittest.cc
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ui/app_list/views/all_apps_tile_item_view.cc
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/f486598b282e1f5399b94b04ca25e7e3bbd12526/ui/app_list/views/search_box_view.cc

Comment 6 by newcomer@chromium.org, Jun 22 2017

Status: Fixed (was: Started)

Comment 7 by willg...@gmail.com, Jun 22 2017 

Question, will the side shelf be tinted when launcher is opened? It currently looks like this:
Screenshot 2017-06-21 at 8.36.42 PM.png
719 KB View Download

Comment 8 by newcomer@chromium.org, Jun 22 2017 

It will be tinted, waiting to land the change.

https://bugs.chromium.org/p/chromium/issues/detail?id=735495

Thanks!

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment