New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731891 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: 2
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 732481



Sign in to add a comment

Add new icons to launcher.

Project Member Reported by newcomer@chromium.org, Jun 9 2017

Issue description

Add new launcher icons to source code and put them in the search bar behind the IsFullscreenAppList feature flag.

 

Comment 1 by warx@chromium.org, Jun 12 2017

Blocking: 732481
Cc: newcomer@chromium.org
Labels: -Pri-3 OS-Chrome Pri-1
Owner: warx@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7ab578dc05583c914b5a1c395df4f6163dbac6e

commit a7ab578dc05583c914b5a1c395df4f6163dbac6e
Author: warx <warx@chromium.org>
Date: Tue Jun 13 23:10:39 2017

cros: add google/mic icons to searchbox

Changes:
(1) add ui/app_list/vector_icons to store new assets and apply them
based on the state that wallpaper color customization is not available.
(2) remove back button in searchbox for new launcher

TODO:
current searchbox background color, icon and hint text color are all
defined assuming that wallpaper color customization is not available.
Modify them when wallpaper color info is available.

R=xiyuan@chromium.org
BUG= 731891 
TEST=device test, with --enable-features=EnableFullscreenAppList flag,
UI is in a correct WIP state. Without flag, it falls to current
behavior.

Review-Url: https://codereview.chromium.org/2941573002
Cr-Commit-Position: refs/heads/master@{#479196}

[modify] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/BUILD.gn
[modify] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/app_list_constants.h
[add] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/vector_icons/ic_google_black.1x.icon
[add] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/vector_icons/ic_google_black.icon
[add] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/vector_icons/ic_mic_black.1x.icon
[add] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/vector_icons/ic_mic_black.icon
[add] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/vector_icons/vector_icons.cc.template
[add] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/vector_icons/vector_icons.h.template
[modify] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/a7ab578dc05583c914b5a1c395df4f6163dbac6e/ui/app_list/views/search_box_view.h

Comment 3 by warx@chromium.org, Jun 27 2017

Labels: NewLauncherUIV1
Status: Fixed (was: Started)
let us close this one, it doesn't have to be an individual issue

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment