Issue metadata
Sign in to add a comment
|
No way to go back or close the "Enter Passphrase" page after entering a wrong passphrase. |
||||||||||||||||||||||
Issue descriptionENVIRONMENT and STATS chrome version: 60.0.3112.20 beta Device: Iphone 7 (ios 10) REPRO STEPS 1. Login in to Chrome on two devices. 2. Set passphrase on one device 3. Open Chrome on the second device (ios) 4. Open "Recent tabs" page and click "ENABLE SYNC" button or 5. Open a new tab and click on the "ENTER PASSPHRASE" button in the pop up at the bottom of the page. 6. Enter wrong passphrase and click submit. ACTUAL RESULTS "Incorrect passphrase" message is displayed and the option to close [X]the page is disappeared. So for the user the only option to go back is to restart Chrome. EXPECTED RESULTS "Incorrect passphrase" message is displayed and the option to close [X]the page is displayed ADDITIONAL INFO Not reproduce when done this from the settings page. Also not reproduced in 59.0.3071.84. This is a regression in M60
,
Jun 14 2017
,
Jun 14 2017
The issue is likely somewhere in sync_encryption_passphrase_collection_view_controller.mm. stkhapugin@ Could you check if the issue is caused by change https://codereview.chromium.org/2813223002
,
Jun 14 2017
nvm. I posted a fix for review.
,
Jun 15 2017
Thank you for taking this on. Link to your CL: https://codereview.chromium.org/2940913002/
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4873f6cb2f8c674cbf7529b69820cd58c2d4df1f commit 4873f6cb2f8c674cbf7529b69820cd58c2d4df1f Author: pavely <pavely@chromium.org> Date: Thu Jun 15 08:37:11 2017 In sync passphrase dialog reset left bar button and title to saved values They are currently reset to nil. R=lpromero@chromium.org BUG= 731887 Review-Url: https://codereview.chromium.org/2940913002 Cr-Commit-Position: refs/heads/master@{#479642} [modify] https://crrev.com/4873f6cb2f8c674cbf7529b69820cd58c2d4df1f/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm
,
Jun 15 2017
,
Jun 15 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
,
Jun 15 2017
Requesting merge to M60. The issue affects UX. There is not UI element to back out of dialog if user gets to passphrase dialog from "Recent tabs" and enters passphrase incorrectly. The fix is trivial and low risk.
,
Jun 15 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 19 2017
https://drive.google.com/open?id=0B6GVWQnhaMClcUVLaUstd045VFk Verified on iPhone7+ iOS 10.2.1 .Close [X] is present.
,
Jun 19 2017
,
Jun 19 2017
https://drive.google.com/open?id=0B6GVWQnhaMClcUVLaUstd045VFk Verified on iPhone7+ iOS 10.2.1 on Canary 61.0.3135.0.Close [X] is present.
,
Jun 20 2017
,
Jun 21 2017
Verified on : Build Version: 60.0.3112.39 Beta Device: iPhone5, iPhone7 iOS Version: 9.3.5, 10.2.1 Issue is fixed. Tested 'Enter Passphrase' from Recent tabs and NTP by entering wrong passphrase,'Incorrect Passphrase' message is displayed with Close [X] option. Please see the screenshots attached.
,
Jun 23 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 23 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pav...@chromium.org
, Jun 14 2017