linux_chromium_ubsan_rel_ng fails on SyncInternalsMessageHandlerTest |
|||
Issue descriptionhttps://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_ubsan_rel_ng/builds/77 Failure message: ../../chrome/browser/sync/profile_sync_service_factory.cc:109:10: runtime error: downcast of address 0x107f842d9900 which does not point to an object of type 'browser_sync::ProfileSyncService' 0x107f842d9900: note: object is of type '(anonymous namespace)::TestSyncService' Over to phajdan.jr@ (from the git blame) for further triage.
,
Jun 16 2017
This was probably my fault, will investigate.
,
Jun 19 2017
Having a difficult time reproducing this exact test failure. Trying to follow the steps at https://www.chromium.org/developers/testing/undefinedbehaviorsanitizer , cannot seem to get is_ubsan_vptr = true to compile, and with is_ubsan = true the tests still seem to pass on my machine. I think the problem is that we construct a TestSyncService but then return it as a ProfileSyncService, and those are in different inheritance branches. I believe the correct path forward would be to convert all the places that call ProfileSyncServiceFactory::GetForProfile to use ProfileSyncServiceFactory::GetSyncServiceForBrowserContext instead in this unit test.
,
Jun 20 2017
,
Jun 28 2017
Sky, are you still looking at this?
,
Jun 28 2017
https://codereview.chromium.org/2948603002/ https://chromium.googlesource.com/chromium/src/+/481300507088191e19ebc7f9d722cb58d80cdcdf This issue is fixed. I'm not sure why this bug didn't get updated when the patch landed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by phajdan.jr@chromium.org
, Jun 16 2017Components: Services>Sync
Owner: ----
Status: Untriaged (was: Assigned)