New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731856 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 2
Type: Bug

Blocking:
issue 625198



Sign in to add a comment

Disable Touch Adjustment for stylus-generated gestures

Project Member Reported by chongz@chromium.org, Jun 9 2017

Issue description

Stylus could generate Tap and Press gestures on Android & ChromeOS, but we actually shouldn't do this since stylus is very precise.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d65eacf7288645732c715f588fc3f5d4ae0e0d81

commit d65eacf7288645732c715f588fc3f5d4ae0e0d81
Author: chongz <chongz@chromium.org>
Date: Wed Jun 28 05:21:59 2017

[Touch Adjustment] Pass primary_pointer_type to WebGestureEvent and disable adjustment for stylus

Event Flow:
1. MotionEvent.GetToolType() =>
2. GestureEventDetails.primary_pointer_type_ =>
3. WebGestureEvent.primary_pointer_type

This CL is intended to fix stylus issue on ChromeOS devices. (e.g. Samsung
Chromebook Plus)

Background:
1. ChromeOS: Stylus generates touch events with large width&height.
2. Android: Stylus generates touch events with 0 width&height.
3. Windows: Stylus generates mouse events.

Manually tested on Samsung Galaxy Note 5 and |primary_pointer_type| was passed
successfully.

BUG= 731856 

Review-Url: https://codereview.chromium.org/2925883003
Cr-Commit-Position: refs/heads/master@{#482892}

[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/content/shell/test_runner/event_sender.cc
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-scrollbar-mainframe.html
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-scrollbar-textarea.html
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-scrollbar.html
[add] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/third_party/WebKit/LayoutTests/touchadjustment/stylus-generated-gesture-tap.html
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/third_party/WebKit/Source/platform/exported/WebInputEvent.cpp
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/third_party/WebKit/public/platform/WebGestureEvent.h
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/ui/events/gesture_detection/gesture_event_data.cc
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/ui/events/gesture_detection/gesture_event_data.h
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/ui/events/gesture_event_details.cc
[modify] https://crrev.com/d65eacf7288645732c715f588fc3f5d4ae0e0d81/ui/events/gesture_event_details.h

Comment 2 by chongz@chromium.org, Oct 13 2017

Labels: M-61
Status: Fixed (was: Started)

Sign in to add a comment