New issue
Advanced search Search tips

Issue 731850 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Trigger SPV2 trybot on test expectation changes

Project Member Reported by pdr@chromium.org, Jun 9 2017

Issue description

When modifying test expectations (e.g., https://chromium-review.googlesource.com/c/528957), it would be useful to trigger the spv2 trybot.

This should just require a small change to https://cs.chromium.org/chromium/src/third_party/WebKit/PRESUBMIT.py?q=third_party/WebKit/presu+package:%5Echromium$&l=310.
 
Labels: PaintTeamTriaged-20170612 BugSource-Team
Are you referring to all test expectations, or just SPv2 flag expectations?

Comment 2 by pdr@chromium.org, Jun 12 2017

I'm thinking just SPV2 flag expectation
Owner: wangxianzhu@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/016f42f92248b8d6c37894f247b6e4e7957fbe5e

commit 016f42f92248b8d6c37894f247b6e4e7957fbe5e
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon Jun 26 19:16:00 2017

Trigger SPv2 trybot on spv2 test expectation change

BUG= 731850 

Change-Id: I2b9ca36110a2889e8234378a16cd6b11f1fbfb7b
Reviewed-on: https://chromium-review.googlesource.com/546837
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482347}
[modify] https://crrev.com/016f42f92248b8d6c37894f247b6e4e7957fbe5e/third_party/WebKit/PRESUBMIT.py

Status: Fixed (was: Started)

Sign in to add a comment