Record NoShow reasons on Desktop |
||||||||
Issue description^^^
,
Jun 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/828269bca0e80beb637e41aa39aa30e41a7dac65 commit 828269bca0e80beb637e41aa39aa30e41a7dac65 Author: sebsg <sebsg@chromium.org> Date: Sat Jun 10 02:54:44 2017 [Payments] Record NoShow reason on Desktop. Bug: 731832 Change-Id: I17e8f65fba85b2dfc1145873f84593611590402a Reviewed-on: https://chromium-review.googlesource.com/529551 Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#478504} [modify] https://crrev.com/828269bca0e80beb637e41aa39aa30e41a7dac65/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc [modify] https://crrev.com/828269bca0e80beb637e41aa39aa30e41a7dac65/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/828269bca0e80beb637e41aa39aa30e41a7dac65/chrome/browser/ui/views/payments/payment_request_journey_logger_browsertest.cc [add] https://crrev.com/828269bca0e80beb637e41aa39aa30e41a7dac65/chrome/test/data/payments/multiple_show.js [add] https://crrev.com/828269bca0e80beb637e41aa39aa30e41a7dac65/chrome/test/data/payments/payment_request_multiple_show_test.html [modify] https://crrev.com/828269bca0e80beb637e41aa39aa30e41a7dac65/components/payments/content/payment_request.cc [modify] https://crrev.com/828269bca0e80beb637e41aa39aa30e41a7dac65/components/payments/core/journey_logger.cc [modify] https://crrev.com/828269bca0e80beb637e41aa39aa30e41a7dac65/components/payments/core/journey_logger.h
,
Jun 10 2017
,
Jun 11 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2017
Hi sebsg@ - since we are already at M60 Beta, can you please confirm if this is absolutely critical change that is needed for M60 or can it wait until M61?
,
Jun 13 2017
We would really like this to be in M60 yes.
,
Jun 14 2017
Approving merge for M60.
,
Jun 15 2017
Please merge the patch to M60 branch(3112) ASAP.
,
Jun 16 2017
Arg, It will be easier to merge after this one: crbug.com/729349
,
Jun 19 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 19 2017
Per comment 9, I need to merge crbug.com/729349 before. Thanks!
,
Jun 20 2017
,
Jun 27 2017
,
Jun 28 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by se...@chromium.org
, Jun 9 2017