New issue
Advanced search Search tips

Issue 731822 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 717776



Sign in to add a comment

DevTools: [regression] allow setting individual console filter levels again.

Project Member Reported by pfeldman@chromium.org, Jun 9 2017

Issue description

Rolling part of the behavior back as a response to the users feedback.

This has landed in https://chromium.googlesource.com/chromium/src/+/1369587070df8d40fb8bffffca8ef525be19616e 3 days ago, no problem on Canary.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 9 2017

Labels: -Merge-Request-60 Merge-Reject-60 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 717776
Labels: -Pri-3 -Merge-Reject-60 -Hotlist-Merge-Reject ReleaseBlock-Beta Merge-Request-60 Pri-1
This change is critical to unblock, major devtools UX regression discovered late in the M58 cycle.

https://bugs.chromium.org/p/chromium/issues/detail?id=717776
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 12 2017

Labels: Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please apply appropriate OSs.  Thanks.
Labels: -Merge-Reject-60 -Hotlist-Merge-Reject
bustamante@: could you review this one?
Labels: ReleaseBlock-Stable
Marking as RBS as per our offline discussion.
Labels: -Merge-Review-60 Merge-Approved-60
Thanks! Approving for merge into M60 at it meets all the requirements.
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 15 2017

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e0b284720b2273b6fd9ce4e12eae8b0934be98b

commit 6e0b284720b2273b6fd9ce4e12eae8b0934be98b
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Thu Jun 15 20:38:35 2017

DevTools: allow setting individual console filter levels.

BUG= 731822 

Review-Url: https://codereview.chromium.org/2920183003
Cr-Original-Commit-Position: refs/heads/master@{#477444}
Review-Url: https://codereview.chromium.org/2941133002 .
Cr-Commit-Position: refs/branch-heads/3112@{#351}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/6e0b284720b2273b6fd9ce4e12eae8b0934be98b/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/6e0b284720b2273b6fd9ce4e12eae8b0934be98b/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test-expected.txt
[modify] https://crrev.com/6e0b284720b2273b6fd9ce4e12eae8b0934be98b/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html
[modify] https://crrev.com/6e0b284720b2273b6fd9ce4e12eae8b0934be98b/third_party/WebKit/LayoutTests/inspector/console/console-tests.html
[modify] https://crrev.com/6e0b284720b2273b6fd9ce4e12eae8b0934be98b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/6e0b284720b2273b6fd9ce4e12eae8b0934be98b/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
[modify] https://crrev.com/6e0b284720b2273b6fd9ce4e12eae8b0934be98b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Project Member

Comment 11 by sheriffbot@chromium.org, Jun 19 2017

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)

Sign in to add a comment