New issue
Advanced search Search tips

Issue 731819 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

url_request_job DCHECK when network is disabled

Project Member Reported by s...@chromium.org, Jun 9 2017

Issue description

After building from ToT, on my Linux workstation I go to the toolbar in the bottom right corner, click on the network icon, and toggle the 'Wired' field so that I am not longer connected to the internet. I initially hit this DCHECK while trying to deleted specific entries from chrome://history (I was also signed in and syncing), but sometimes I seem to hit this DCHECK very soon after disabling the network.

[43905:43932:0609/113211.298583:FATAL:url_request_job.cc(874)] Check failed: total_sent_bytes >= last_notified_total_sent_bytes_ (-356 vs. 0)
#0 0x7f9799b12a5b base::debug::StackTrace::StackTrace()
#1 0x7f9799b1175c base::debug::StackTrace::StackTrace()
#2 0x7f9799b85313 logging::LogMessage::~LogMessage()
#3 0x7f979946f1a5 net::URLRequestJob::MaybeNotifyNetworkBytes()
#4 0x7f97994705b1 net::URLRequestJob::NotifyStartError()
#5 0x7f9799463cb8 net::URLRequestHttpJob::OnStartCompleted()
#6 0x7f9798b7dfac _ZN4base8internal13FunctorTraitsIMN3net18ClientSocketHandleEFviEvE6InvokeIPS3_JiEEEvS5_OT_DpOT0_
#7 0x7f9799469c06 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3net17URLRequestHttpJobEFviEJPS5_iEEEvOT_DpOT0_
#8 0x7f9799469b97 _ZN4base8internal7InvokerINS0_9BindStateIMN3net17URLRequestHttpJobEFviEJNS0_17UnretainedWrapperIS4_EEEEEFviEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOi
#9 0x7f9799469acc _ZN4base8internal7InvokerINS0_9BindStateIMN3net17URLRequestHttpJobEFviEJNS0_17UnretainedWrapperIS4_EEEEEFviEE3RunEPNS0_13BindStateBaseEOi
#10 0x7f9798b8e9d2 _ZNO4base8CallbackIFviELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEi
#11 0x7f9798eed834 net::HttpCache::Transaction::DoLoop()
#12 0x7f9798eeb66b net::HttpCache::Transaction::OnIOComplete()
#13 0x7f9798dcd58e _ZN4base8internal13FunctorTraitsIMN10disk_cache11SimpleIndexEFviEvE6InvokeIRKNS_7WeakPtrIS3_EEJiEEEvS5_OT_DpOT0_
#14 0x7f9798f02a5f _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN3net9HttpCache11TransactionEFviERKNS_7WeakPtrIS6_EEJiEEEvOT_OT0_DpOT1_
#15 0x7f9798f029d7 _ZN4base8internal7InvokerINS0_9BindStateIMN3net9HttpCache11TransactionEFviEJNS_7WeakPtrIS5_EEEEEFviEE7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOi
#16 0x7f9798f0290c _ZN4base8internal7InvokerINS0_9BindStateIMN3net9HttpCache11TransactionEFviEJNS_7WeakPtrIS5_EEEEEFviEE3RunEPNS0_13BindStateBaseEOi
#17 0x7f9798b7da41 _ZNKR4base8CallbackIFviELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEi
#18 0x7f9798f1d55d net::HttpNetworkTransaction::DoCallback()
#19 0x7f9798f18698 net::HttpNetworkTransaction::OnIOComplete()
#20 0x7f9798f1c194 net::HttpNetworkTransaction::OnStreamReady()
#21 0x7f9798f99279 net::HttpStreamFactoryImpl::Request::OnStreamReady()
#22 0x7f9798f8ef3b net::HttpStreamFactoryImpl::JobController::OnStreamReady()
#23 0x7f9798f7e22d net::HttpStreamFactoryImpl::Job::OnStreamReadyCallback()
#24 0x7f9798c42d97 _ZN4base8internal13FunctorTraitsIMN3net26NetworkThrottleManagerImplEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_
#25 0x7f9798f86b5a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN3net21HttpStreamFactoryImpl3JobEFvvERKNS_7WeakPtrIS6_EEJEEEvOT_OT0_DpOT1_
#26 0x7f9798f86ae2 _ZN4base8internal7InvokerINS0_9BindStateIMN3net21HttpStreamFactoryImpl3JobEFvvEJNS_7WeakPtrIS5_EEEEEFvvEE7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#27 0x7f9798f86a2c _ZN4base8internal7InvokerINS0_9BindStateIMN3net21HttpStreamFactoryImpl3JobEFvvEJNS_7WeakPtrIS5_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#28 0x7f9799ace23e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#29 0x7f9799b186be base::debug::TaskAnnotator::RunTask()
#30 0x7f9799baf33d base::MessageLoop::RunTask()
#31 0x7f9799baf5c7 base::MessageLoop::DeferOrRunPendingTask()
#32 0x7f9799baf8df base::MessageLoop::DoWork()
#33 0x7f9799bc47ce base::MessagePumpLibevent::Run()
#34 0x7f9799baed08 base::MessageLoop::Run()
#35 0x7f9799c5883d base::RunLoop::Run()
#36 0x7f9799d08554 base::Thread::Run()
#37 0x7f9792bacf16 content::BrowserThreadImpl::IOThreadRun()
#38 0x7f9792bad21b content::BrowserThreadImpl::Run()
#39 0x7f9799d08dba base::Thread::ThreadMain()
#40 0x7f9799cef5aa base::(anonymous namespace)::ThreadFunc()
#41 0x7f979a04f184 start_thread
#42 0x7f977fe73bed clone

Received signal 6
#0 0x7f9799b12a5b base::debug::StackTrace::StackTrace()
#1 0x7f9799b1175c base::debug::StackTrace::StackTrace()
#2 0x7f9799b1256f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7f979a057330 <unknown>
#4 0x7f977fdacc37 gsignal
#5 0x7f977fdb0028 abort
#6 0x7f9799b0f756 base::debug::(anonymous namespace)::DebugBreak()
#7 0x7f9799b0f738 base::debug::BreakDebugger()
#8 0x7f9799b85794 logging::LogMessage::~LogMessage()
#9 0x7f979946f1a5 net::URLRequestJob::MaybeNotifyNetworkBytes()
#10 0x7f97994705b1 net::URLRequestJob::NotifyStartError()
#11 0x7f9799463cb8 net::URLRequestHttpJob::OnStartCompleted()
#12 0x7f9798b7dfac _ZN4base8internal13FunctorTraitsIMN3net18ClientSocketHandleEFviEvE6InvokeIPS3_JiEEEvS5_OT_DpOT0_
#13 0x7f9799469c06 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3net17URLRequestHttpJobEFviEJPS5_iEEEvOT_DpOT0_
#14 0x7f9799469b97 _ZN4base8internal7InvokerINS0_9BindStateIMN3net17URLRequestHttpJobEFviEJNS0_17UnretainedWrapperIS4_EEEEEFviEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOi
#15 0x7f9799469acc _ZN4base8internal7InvokerINS0_9BindStateIMN3net17URLRequestHttpJobEFviEJNS0_17UnretainedWrapperIS4_EEEEEFviEE3RunEPNS0_13BindStateBaseEOi
#16 0x7f9798b8e9d2 _ZNO4base8CallbackIFviELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEi
#17 0x7f9798eed834 net::HttpCache::Transaction::DoLoop()
#18 0x7f9798eeb66b net::HttpCache::Transaction::OnIOComplete()
#19 0x7f9798dcd58e _ZN4base8internal13FunctorTraitsIMN10disk_cache11SimpleIndexEFviEvE6InvokeIRKNS_7WeakPtrIS3_EEJiEEEvS5_OT_DpOT0_
#20 0x7f9798f02a5f _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN3net9HttpCache11TransactionEFviERKNS_7WeakPtrIS6_EEJiEEEvOT_OT0_DpOT1_
#21 0x7f9798f029d7 _ZN4base8internal7InvokerINS0_9BindStateIMN3net9HttpCache11TransactionEFviEJNS_7WeakPtrIS5_EEEEEFviEE7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOi
#22 0x7f9798f0290c _ZN4base8internal7InvokerINS0_9BindStateIMN3net9HttpCache11TransactionEFviEJNS_7WeakPtrIS5_EEEEEFviEE3RunEPNS0_13BindStateBaseEOi
#23 0x7f9798b7da41 _ZNKR4base8CallbackIFviELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEi
#24 0x7f9798f1d55d net::HttpNetworkTransaction::DoCallback()
#25 0x7f9798f18698 net::HttpNetworkTransaction::OnIOComplete()
#26 0x7f9798f1c194 net::HttpNetworkTransaction::OnStreamReady()
#27 0x7f9798f99279 net::HttpStreamFactoryImpl::Request::OnStreamReady()
#28 0x7f9798f8ef3b net::HttpStreamFactoryImpl::JobController::OnStreamReady()
#29 0x7f9798f7e22d net::HttpStreamFactoryImpl::Job::OnStreamReadyCallback()
#30 0x7f9798c42d97 _ZN4base8internal13FunctorTraitsIMN3net26NetworkThrottleManagerImplEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_
#31 0x7f9798f86b5a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN3net21HttpStreamFactoryImpl3JobEFvvERKNS_7WeakPtrIS6_EEJEEEvOT_OT0_DpOT1_
#32 0x7f9798f86ae2 _ZN4base8internal7InvokerINS0_9BindStateIMN3net21HttpStreamFactoryImpl3JobEFvvEJNS_7WeakPtrIS5_EEEEEFvvEE7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#33 0x7f9798f86a2c _ZN4base8internal7InvokerINS0_9BindStateIMN3net21HttpStreamFactoryImpl3JobEFvvEJNS_7WeakPtrIS5_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#34 0x7f9799ace23e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#35 0x7f9799b186be base::debug::TaskAnnotator::RunTask()
#36 0x7f9799baf33d base::MessageLoop::RunTask()
#37 0x7f9799baf5c7 base::MessageLoop::DeferOrRunPendingTask()
#38 0x7f9799baf8df base::MessageLoop::DoWork()
#39 0x7f9799bc47ce base::MessagePumpLibevent::Run()
#40 0x7f9799baed08 base::MessageLoop::Run()
#41 0x7f9799c5883d base::RunLoop::Run()
#42 0x7f9799d08554 base::Thread::Run()
#43 0x7f9792bacf16 content::BrowserThreadImpl::IOThreadRun()
#44 0x7f9792bad21b content::BrowserThreadImpl::Run()
#45 0x7f9799d08dba base::Thread::ThreadMain()
#46 0x7f9799cef5aa base::(anonymous namespace)::ThreadFunc()
#47 0x7f979a04f184 start_thread
#48 0x7f977fe73bed clone
  r8: fffffffffffffed8  r9: fffffffffffffec8 r10: 0000000000000008 r11: 0000000000000206
 r12: 0000000000000000 r13: 0000000000000000 r14: 00007f9767e719c0 r15: 00007f9767e71700
  di: 000000000000ab81  si: 000000000000ab9c  bp: 00007f9767e69000  bx: 0000000000000000
  dx: 0000000000000006  ax: 0000000000000000  cx: 00007f977fdacc37  sp: 00007f9767e68ec8
  ip: 00007f977fdacc37 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.
 

Comment 1 by mmenke@chromium.org, Jun 14 2017

Components: -Internals>Network Internals>Network>QUIC
Owner: mmenke@chromium.org
Status: Assigned (was: Untriaged)
I bet what's happening is were adding a network error code to total_bytes_sent.  -356 is ERR_QUIC_PROTOCOL_ERROR, so this is probably a QUIC bug.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffff364f06b3fa261dcf249ded47675c2d0d48a3

commit ffff364f06b3fa261dcf249ded47675c2d0d48a3
Author: mmenke <mmenke@chromium.org>
Date: Thu Jun 15 17:37:24 2017

Fix QuicHttpStream reporting negative sent bytes.

It was treating error codes as number of header bytes sent.
This may have affected metrics slightly, not sure if it had any
had any web-visible ordevtools-visible effects.

BUG= 731819 

Review-Url: https://codereview.chromium.org/2937113002
Cr-Commit-Position: refs/heads/master@{#479749}

[modify] https://crrev.com/ffff364f06b3fa261dcf249ded47675c2d0d48a3/net/quic/chromium/quic_http_stream.cc
[modify] https://crrev.com/ffff364f06b3fa261dcf249ded47675c2d0d48a3/net/quic/chromium/quic_http_stream_test.cc

Comment 3 by mmenke@chromium.org, Jun 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment