Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 6 users
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment
Implement Deprecation Reports, ReportingObserver
Project Member Reported by paulmeyer@chromium.org, Jun 9 Back to list
Change description:
These features are closely related to the previously proposed Reporting API (https://bugs.chromium.org/p/chromium/issues/detail?id=676016). Deprecation reports are one type of report be routed into the Reporting API backend. ReportingObserver is a new observer that will allow developers to observe reports from JavaScript.

See this explainer (https://github.com/WICG/reporting/blob/master/EXPLAINER.md#basic-report-formats) for more details.

Changes to API surface:
* Adds ReportingObserver
* Adds ability for Deprecation reports to be sent into the new Reporting API backend.

Links:
Public standards discussion: https://github.com/WICG/reporting/issues/27
https://github.com/WICG/reporting/issues/29

Support in other browsers:
Internet Explorer: Not implemented.
Firefox: Not implemented.
Safari: Not implemented.


 
Project Member Comment 2 by bugdroid1@chromium.org, Jul 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67d19ec113dae3c7ff99374085eb3240b0d4cfd9

commit 67d19ec113dae3c7ff99374085eb3240b0d4cfd9
Author: Paul Meyer <paulmeyer@chromium.org>
Date: Wed Jul 26 17:57:25 2017

Create ReportingObserver and DeprecationReports.

This patch both implements ReportingObserver, and generates DeprecationReports to route to ReportingObservers.

See this explainer for more details on these features (working spec): https://github.com/WICG/reporting/blob/master/EXPLAINER.md

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/B1oztuLlzxg

Bug: 731810
Change-Id: If6ebab0aa106788b97f8ef5b0b64540171387923
Reviewed-on: https://chromium-review.googlesource.com/564016
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489690}
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/LayoutTests/reporting-observer/deprecation.html
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/LayoutTests/reporting-observer/resources/deprecation.js
[modify] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/BUILD.gn
[modify] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/Deprecation.h
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/DeprecationReport.h
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/DeprecationReport.idl
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/Report.h
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/Report.idl
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/ReportBody.h
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/ReportBody.idl
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/ReportingContext.cpp
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/ReportingContext.h
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/ReportingObserver.cpp
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/ReportingObserver.h
[add] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/core/frame/ReportingObserver.idl
[modify] https://crrev.com/67d19ec113dae3c7ff99374085eb3240b0d4cfd9/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Cc: juliatut...@chromium.org
Components: Blink>ReportingObserver
Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Summary: Implement Deprecation Reports, ReportingObserver (was: OWP Launch: Deprecation Reports, ReportingObserver)
Project Member Comment 7 by bugdroid1@chromium.org, Sep 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eac569dd8d418fdd8071be8b747e03df09308ed

commit 8eac569dd8d418fdd8071be8b747e03df09308ed
Author: Paul Meyer <paulmeyer@chromium.org>
Date: Thu Sep 21 05:31:34 2017

Generate intervention reports and route them to ReportingObserver.

This patch implements a centralized location for the generation of
intervention reports, which both sends a message to the console,
and routes the reports to any registered ReportingObservers.

This patch also connects the existing interventions in TouchEvent to
utilize this new flow. Other interventions will need to be connected in
future patches.

Bug: 564071, 731810
Change-Id: I0aa435ca6ebfe5950fbcd8795b678852a55f5d28
Reviewed-on: https://chromium-review.googlesource.com/652958
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503363}
[modify] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/LayoutTests/reporting-observer/deprecation.html
[add] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/LayoutTests/reporting-observer/intervention.html
[add] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/LayoutTests/reporting-observer/resources/intervention.js
[modify] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/Source/core/events/TouchEvent.cpp
[modify] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/Source/core/events/TouchEventTest.cpp
[modify] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/Source/core/frame/BUILD.gn
[add] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/Source/core/frame/Intervention.cpp
[add] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/Source/core/frame/Intervention.h
[add] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/Source/core/frame/InterventionReport.h
[add] https://crrev.com/8eac569dd8d418fdd8071be8b747e03df09308ed/third_party/WebKit/Source/core/frame/InterventionReport.idl

Project Member Comment 8 by bugdroid1@chromium.org, Sep 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f40912dcc43c0ff9447e914c606c8052f281668

commit 8f40912dcc43c0ff9447e914c606c8052f281668
Author: Paul Meyer <paulmeyer@chromium.org>
Date: Tue Sep 26 23:57:18 2017

Hook deprecation reports up to Reporting API

This patch connects deprecation reports (which are already routed into
ReportingObserver) to the ReporingServiceProxy mojo interface.

Bug: 731810, 564071
Change-Id: I3885ae8c723b407628eb6d931b097521e9b89526
Reviewed-on: https://chromium-review.googlesource.com/646638
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504528}
[add] https://crrev.com/8f40912dcc43c0ff9447e914c606c8052f281668/third_party/WebKit/LayoutTests/reporting-observer/reporting-api.html
[modify] https://crrev.com/8f40912dcc43c0ff9447e914c606c8052f281668/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/8f40912dcc43c0ff9447e914c606c8052f281668/third_party/WebKit/Source/core/frame/DeprecationReport.h

Project Member Comment 9 by bugdroid1@chromium.org, Sep 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f808263890954e2c8c4fc86ed4e48f54ac8ce26

commit 6f808263890954e2c8c4fc86ed4e48f54ac8ce26
Author: Paul Meyer <paulmeyer@chromium.org>
Date: Thu Sep 28 01:05:07 2017

Hook intervention reports up to Reporting API

This patch connects intervention reports to the ReporingServiceProxy mojo
interface.

Notes on testing: 
1) The test for this patch's new functionality is added to reporting-api.html,
where the mock reporting class there can be reused.
2) This patch also factors out the intervention-generating code to a
function in intervention.js, so it can be used in both reporting-api.html
and intervention.html tests.

Bug: 731810, 564071
Change-Id: I9ea961f6672ece81712c657ee7d9350b0520bb29
Reviewed-on: https://chromium-review.googlesource.com/685992
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504850}
[modify] https://crrev.com/6f808263890954e2c8c4fc86ed4e48f54ac8ce26/third_party/WebKit/LayoutTests/reporting-observer/intervention.html
[modify] https://crrev.com/6f808263890954e2c8c4fc86ed4e48f54ac8ce26/third_party/WebKit/LayoutTests/reporting-observer/reporting-api.html
[modify] https://crrev.com/6f808263890954e2c8c4fc86ed4e48f54ac8ce26/third_party/WebKit/LayoutTests/reporting-observer/resources/intervention.js
[modify] https://crrev.com/6f808263890954e2c8c4fc86ed4e48f54ac8ce26/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/6f808263890954e2c8c4fc86ed4e48f54ac8ce26/third_party/WebKit/Source/core/frame/Intervention.cpp
[modify] https://crrev.com/6f808263890954e2c8c4fc86ed4e48f54ac8ce26/third_party/WebKit/Source/core/frame/InterventionReport.h

Sign in to add a comment