New issue
Advanced search Search tips

Issue 731801 link

Starred by 2 users
Status: Fixed
Owner:
thildebr@chromium.org
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Null icon causes crash in Instant Apps Infobar

Project Member Reported by mariakho...@chromium.org, Jun 9 2017 
There a cases where LaunchData.getApplicationIcon() can return null.

Generally infobar code is able to handle that situation, but in InstantAppsInfobar, we call setIsUsingBigIcon(), which assumes icon's presence. Do a null check for icon before making that call (or fix setIsUsingBigIcon to do null check) so that we don't get NPE in those circumstances.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a34648550e4e95f355854e937c0cb1a095833681

commit a34648550e4e95f355854e937c0cb1a095833681
Author: thildebr <thildebr@chromium.org>
Date: Mon Jun 12 22:11:10 2017

Add null check to InfoBarLayout.setIsUsingBigIcon to avoid NPE.

It's possible for us to get a null icon from getInstantAppLaunchData, so
perform a null check before using the icon in InfoBarLayout.

BUG= 731801 

Review-Url: https://codereview.chromium.org/2936703002
Cr-Commit-Position: refs/heads/master@{#478787}

[modify] https://crrev.com/a34648550e4e95f355854e937c0cb1a095833681/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java

Comment 2 by thildebr@chromium.org, Jun 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment