New issue
Advanced search Search tips

Issue 731800 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

git cl archive not detecting local branch associated with merged Gerrit issue

Project Member Reported by carlosk@chromium.org, Jun 9 2017

Issue description

I have a local branch associated with a Gerrit issue [1] that is already merged/submitted. When I run "git cl archive" on my local repo it finds no branches to archive. Is that still not fully working?

[1] https://chromium-review.googlesource.com/c/526812/
 

Comment 1 by aga...@chromium.org, Jun 12 2017

Cc: aga...@chromium.org
Components: -Infra>Git -Infra>Codereview>Gerrit Infra>SDK
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
assigning to tandrii who created git-cl-archive, but I have some guesses:

If you run "git map-branches -vvv", does it correctly show the branch correlated with the submitted review?

If you run "git config gerrit.host true", does "git cl archive" then work?
I didn't actually create the command, but I did publicize it as a "easier to grasp, but less powerful alternative to `git rebase-update`".

I have same guesses as agable@ though, but TBH I've not tried "git cl archive" recently.
Owner: carlosk@chromium.org
Owner: aga...@chromium.org
Re #1:

> If you run "git map-branches -vvv", does it correctly show the branch correlated with the submitted review?

Yes it does. This is the output for that branch:

last_n-launch-to-stable        8486575ad308 [ ahead 2 | behind 139 ]        https://chromium-review.googlesource.com/526812 (closed)


> If you run "git config gerrit.host true", does "git cl archive" then work?

Interestingly it did work. But I ran "git config gerrit.host" before setting the value to "true" as you suggested and it was already set to "true". So I'm unsure if this was what actually fixed it or some other update in the meantime...?

So, I guess this is fixed but I'm reassigning to agable@ to see if there's anything else to check.

Comment 5 by aga...@chromium.org, Jun 13 2017

Status: WontFix (was: Assigned)
Woah then I definitely have no idea what happened. My two questions were based on these guesses:
1) Maybe something happened to disassociate the local branch from the review. This turned out not to be the case.
2) Maybe "git cl archive" only archives branches associated with your current default codereview system, but that appears to not be the case either.

I'm going to close this as wontfix since we can't reproduce, but if you run into it again definitely let me know.

Sign in to add a comment