Exclude information from local network connections when computing network quality estimate |
||||||
Issue descriptionNQE should exclude RTTs from sockets to local private subnets when computing RTT estimate. Similarly, NQE should refrain from computing throughput observation if there is a request to a private subnet in place. See https://github.com/WICG/netinfo/issues/58#issuecomment-307452481 for more context.
,
Jun 13 2017
,
Jun 13 2017
,
Jun 13 2017
,
Jun 19 2017
,
Jun 19 2017
https://codereview.chromium.org/2936823002/ fixed this bug.
,
Jun 19 2017
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee458c83c928a3c8bf1d5e067628309e5582c2c5 commit ee458c83c928a3c8bf1d5e067628309e5582c2c5 Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Jul 05 21:20:51 2017 Do not log DNS resolution entries from NQE in the netlog Currently, when Network Quality Estimator (NQE) resolves a DNS address, the details of it are logged into the netlog. This is unnecessary, and adds noise. The CL provides an empty NetLogWithSource to the host resolver to prevent logging. Bug: 731797 Change-Id: I6fd6c8529b3766dfd3c777c52bfcbc63e0a911b7 Reviewed-on: https://chromium-review.googlesource.com/557819 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#484353} [modify] https://crrev.com/ee458c83c928a3c8bf1d5e067628309e5582c2c5/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/ee458c83c928a3c8bf1d5e067628309e5582c2c5/net/nqe/network_quality_estimator_util.cc [modify] https://crrev.com/ee458c83c928a3c8bf1d5e067628309e5582c2c5/net/nqe/network_quality_estimator_util.h [modify] https://crrev.com/ee458c83c928a3c8bf1d5e067628309e5582c2c5/net/nqe/network_quality_estimator_util_unittest.cc [modify] https://crrev.com/ee458c83c928a3c8bf1d5e067628309e5582c2c5/net/nqe/throughput_analyzer.cc [modify] https://crrev.com/ee458c83c928a3c8bf1d5e067628309e5582c2c5/net/nqe/throughput_analyzer_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, Jun 9 2017