New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731783 link

Starred by 1 user
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Jun 2017
Cc:
█ hubbe@chromium.org
enne@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 713891



Sign in to add a comment

color: layout test fast/media/mq-color-gamut-api.html fails with --enable-color-correct-rendering

Project Member Reported by ccameron@chromium.org, Jun 9 2017 
The Javascript API testRunner.setColorProfile is racy (with respect to rendering results) with --enable-color-correct-rendering, and has been disabled.

But, fast/media/mq-color-gamut-api.html depends on this API (in a non-racy way).

We're testing non-sRGB rendering in the virtual/exotic-color-profile tests now, so we can remove the old uses of testRunner.setColorProfile, then un-break the API, and then re-enable this test.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83728155df4b26ad4cd2eed5238eb109b74c609

commit f83728155df4b26ad4cd2eed5238eb109b74c609
Author: ccameron <ccameron@chromium.org>
Date: Tue Jun 13 06:49:16 2017

Remove almost all Javascript calls to setColorProfile

We're using virtual test suites to test different color profiles, not
Javascript APIs.

We may keep these for just the gamut query tests.

TBR=enne
BUG= 731783 

Review-Url: https://codereview.chromium.org/2938543003
Cr-Commit-Position: refs/heads/master@{#478915}

[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-animate-rotate.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-animate.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-background-clip-text.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-background-image-cover.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-background-image-cross-fade-png.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-background-image-cross-fade.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-background-image-repeat.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-background-image-space.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-border-fade.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-border-image-source.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-border-image.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-border-radius.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-clip.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-drag-image.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-filter.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-group.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-iframe.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image-canvas-pattern.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image-canvas-svg.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image-canvas.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image-filter-all.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image-object-fit.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image-profile-match.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image-pseudo-content.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image-shape.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image-svg-resource-url.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-image.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-layer-filter.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-layer.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-mask-image-svg.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-object.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-reflection.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-svg-fill-text.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-svg-foreign-object.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/color-profile-svg.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/images/resources/color-checker-munsell-chart.js
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/media/color-profile-video-poster-image.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/media/color-profile-video-seek-filter.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/media/color-profile-video-seek-object-fit.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/media/color-profile-video-seek.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/media/color-profile-video.html
[modify] https://crrev.com/f83728155df4b26ad4cd2eed5238eb109b74c609/third_party/WebKit/LayoutTests/media/resources/munsell-video-chart.js
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/188ad8e21510e3e8ff10465711c11a13a28936f3

commit 188ad8e21510e3e8ff10465711c11a13a28936f3
Author: ccameron <ccameron@chromium.org>
Date: Wed Jun 14 06:58:25 2017

Re-enable media query API test

Remove the remaining images tests that used the JS setColorProfile API, and
re-enable the media query API test.

The media query picture test needs rebaselineing and is in a separate patch.

TBR=enne (for the not-lazy solution)
TBR=avi (for content/)
BUG= 731783 

Review-Url: https://codereview.chromium.org/2936163002
Cr-Commit-Position: refs/heads/master@{#479310}

[modify] https://crrev.com/188ad8e21510e3e8ff10465711c11a13a28936f3/content/renderer/render_view_impl.cc
[modify] https://crrev.com/188ad8e21510e3e8ff10465711c11a13a28936f3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/188ad8e21510e3e8ff10465711c11a13a28936f3/third_party/WebKit/LayoutTests/images/color-profile-image-canvas-svg.html
[modify] https://crrev.com/188ad8e21510e3e8ff10465711c11a13a28936f3/third_party/WebKit/LayoutTests/images/color-profile-image-canvas.html
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5825e6768fa612c2185540a66c02250fa031c28c

commit 5825e6768fa612c2185540a66c02250fa031c28c
Author: ccameron <ccameron@chromium.org>
Date: Thu Jun 15 04:44:57 2017

Rebaseline and re-enable media query gamut picture test

BUG= 731783 
TBR=enne

Review-Url: https://codereview.chromium.org/2935303002
Cr-Commit-Position: refs/heads/master@{#479605}

[modify] https://crrev.com/5825e6768fa612c2185540a66c02250fa031c28c/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/51a69bcf539116e6d8ab573dc9ca263a61023ec2/third_party/WebKit/LayoutTests/fast/media/mq-color-gamut-picture-expected.html
[add] https://crrev.com/5825e6768fa612c2185540a66c02250fa031c28c/third_party/WebKit/LayoutTests/platform/linux/fast/media/mq-color-gamut-picture-expected.png
[add] https://crrev.com/5825e6768fa612c2185540a66c02250fa031c28c/third_party/WebKit/LayoutTests/platform/mac/fast/media/mq-color-gamut-picture-expected.png
[add] https://crrev.com/5825e6768fa612c2185540a66c02250fa031c28c/third_party/WebKit/LayoutTests/platform/mac/fast/media/mq-color-gamut-picture-expected.txt
[add] https://crrev.com/5825e6768fa612c2185540a66c02250fa031c28c/third_party/WebKit/LayoutTests/platform/win/fast/media/mq-color-gamut-picture-expected.png
[add] https://crrev.com/5825e6768fa612c2185540a66c02250fa031c28c/third_party/WebKit/LayoutTests/platform/win/fast/media/mq-color-gamut-picture-expected.txt

Comment 4 by ccameron@chromium.org, Jun 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment