too many different setting mechanisms for min_filelist_kbytes |
|
Issue descriptionFor caroline, we still have an override for vm.min_filelist_kbytes in /etc/sysctl.d (see the chromeos-bsp-caroline-private ebuild) but there is a new mechanism in /usr/share/cros/init/swap.sh which can interfere unpredictable when we start using it. The sysctl setting needs to move to /etc/swap/min_filelist_kbytes. We also have: arc-start-sysctl.conf:exec sysctl vm.min_filelist_kbytes=400000 arc-stop-sysctl.conf:exec sysctl vm.min_filelist_kbytes=100000 so currently any override setting may disappear on ARC start/stop. Swap.sh (which handles the overrides) doesn't have knowledge of the dual value setting. The simplest fix would be to allow only the high value to be configurable, and make the upstart scripts obtain it from new commands in swap.sh.
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a2065a66072a4067ef284a7b7839c57511a62b17 commit a2065a66072a4067ef284a7b7839c57511a62b17 Author: Luigi Semenzato <semenzato@chromium.org> Date: Wed Jun 21 04:56:55 2017 swap.sh: add get_target_value() This lets other code query the chosen target value for various memory manager parameters (for instance min_filelist_kbytes). This also fixes the default value(s) for min_filelist_kbytes in the ARC++ and non-ARC++ cases so that everything runs correctly. BUG=chromium:731762 TEST=ran manually CQ-DEPEND=CL:*397751, CL:*397453, CL:*398209 Change-Id: Ib120250bafb880c89737ce86b48b9a017f854b10 Reviewed-on: https://chromium-review.googlesource.com/540671 Commit-Ready: Luigi Semenzato <semenzato@chromium.org> Tested-by: Luigi Semenzato <semenzato@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/a2065a66072a4067ef284a7b7839c57511a62b17/chromeos-base/swap-init/files/init/swap.sh [rename] https://crrev.com/a2065a66072a4067ef284a7b7839c57511a62b17/chromeos-base/swap-init/swap-init-0.0.1-r17.ebuild [modify] https://crrev.com/a2065a66072a4067ef284a7b7839c57511a62b17/chromeos-base/chromeos-base/files/00-sysctl.conf
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a2065a66072a4067ef284a7b7839c57511a62b17 commit a2065a66072a4067ef284a7b7839c57511a62b17 Author: Luigi Semenzato <semenzato@chromium.org> Date: Wed Jun 21 04:56:55 2017 swap.sh: add get_target_value() This lets other code query the chosen target value for various memory manager parameters (for instance min_filelist_kbytes). This also fixes the default value(s) for min_filelist_kbytes in the ARC++ and non-ARC++ cases so that everything runs correctly. BUG=chromium:731762 TEST=ran manually CQ-DEPEND=CL:*397751, CL:*397453, CL:*398209 Change-Id: Ib120250bafb880c89737ce86b48b9a017f854b10 Reviewed-on: https://chromium-review.googlesource.com/540671 Commit-Ready: Luigi Semenzato <semenzato@chromium.org> Tested-by: Luigi Semenzato <semenzato@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/a2065a66072a4067ef284a7b7839c57511a62b17/chromeos-base/swap-init/files/init/swap.sh [rename] https://crrev.com/a2065a66072a4067ef284a7b7839c57511a62b17/chromeos-base/swap-init/swap-init-0.0.1-r17.ebuild [modify] https://crrev.com/a2065a66072a4067ef284a7b7839c57511a62b17/chromeos-base/chromeos-base/files/00-sysctl.conf
,
Jun 21 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-caroline-private/+/cbfe7518f9f4a289ee95507df00f71726a900c26 commit cbfe7518f9f4a289ee95507df00f71726a900c26 Author: Luigi Semenzato <semenzato@chromium.org> Date: Wed Jun 21 04:56:54 2017
,
Jun 21 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/cheets-scripts/+/44d820bae57d055f8c1f198664b6b3d42e0e2cb3 commit 44d820bae57d055f8c1f198664b6b3d42e0e2cb3 Author: Luigi Semenzato <semenzato@chromium.org> Date: Wed Jun 21 04:56:55 2017 |
|
►
Sign in to add a comment |
|
Comment 1 by vapier@chromium.org
, Jun 9 2017