New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731758 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 721367



Sign in to add a comment

show geolocation-in-use indicator when browsing in VR

Project Member Reported by vollick@chromium.org, Jun 9 2017

Issue description

We should show an indicator in this mode.
 
Labels: -Pri-2 Pri-1
Summary: show geolocation-in-use affordance when browsing in VR (was: show location affordance when browsing in VR)
Labels: Proj-VR-Shell
Issue 731864 could affect this.
Summary: show geolocation-in-use indicator when browsing in VR (was: show geolocation-in-use affordance when browsing in VR)
Status: Started (was: Assigned)
Labels: VR-BBB
The indicator is landed.

https://chromium-review.googlesource.com/535656
Add location access indicator

The location access indicator is added.
SystemIndicatorTexture is modified to handle indicators without text message.

BUG= 731758 

Change-Id: I5bd2219046a00604473aa43d3d9b0e1c80c861d0
Reviewed-on: https://chromium-review.googlesource.com/535656
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480503}
Blocking: 721367
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0

commit 839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0
Author: asimjour <asimjour@chromium.org>
Date: Wed Jul 12 22:04:50 2017

Add GeolocationConfig interface

GeolocationConfig is designed to be used from the chrome/browser.
For now the only method is IsHighAccuracyLocationBeingCaptured, that
indicates if the location is captured with high_accuracy=enabled flag.

BUG= 731758 

Review-Url: https://codereview.chromium.org/2975683002
Cr-Commit-Position: refs/heads/master@{#486123}

[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/chrome/browser/vr/ui_interface.h
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/content/browser/service_manager/common_browser_interfaces.cc
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/device/geolocation/BUILD.gn
[add] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/device/geolocation/geolocation_config.cc
[add] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/device/geolocation/geolocation_config.h
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/device/geolocation/geolocation_provider.h
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/device/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/device/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/device/geolocation/public/interfaces/BUILD.gn
[add] https://crrev.com/839ce1be4b4cdc2a0f92bd0da4fc1fe3d10f67e0/device/geolocation/public/interfaces/geolocation_config.mojom

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f4c88367d049cbdf31f53e543456fd63ff72b17

commit 3f4c88367d049cbdf31f53e543456fd63ff72b17
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Mon Jul 17 19:53:52 2017

Fix comment in GeolocationConfig mojo interface

The comment in .mojom file is fixed.

BUG= 731758 

Change-Id: I110c4220e6fa2f7bd49ed9786d8f21015c955e95
Reviewed-on: https://chromium-review.googlesource.com/571031
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487205}
[modify] https://crrev.com/3f4c88367d049cbdf31f53e543456fd63ff72b17/device/geolocation/public/interfaces/geolocation_config.mojom

Status: Verified (was: Fixed)

Sign in to add a comment