New issue
Advanced search Search tips

Issue 731756 link

Starred by 1 user
Status: Fixed
Owner:
yosin@chromium.org
Closed: Jun 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 679977



Sign in to add a comment

rewrite editing tests to use w3c test harness

Project Member Reported by skobes@chromium.org, Jun 9 2017 
Some editing tests dump the render tree with pixel results.  Examples include:

  editing/inserting/edited-whitespace-1.html
  editing/inserting/typing-at-end-of-line.html

It would be better for these tests to be written using testharness.js and assert_selection() to express their expectation.

Comment 1 by skobes@chromium.org, Jun 9 2017 

(See http://crrev.com/c/527421 review thread for additional context.)

Comment 2 by yosin@chromium.org, Jun 12 2017

Blocking: 679977
Cc: -yosin@chromium.org
Status: Available (was: Unconfirmed)
As of June 12, we have 900 *-expected.txt under LayoutTest/editing/
we have 257 *.png under LayoutTest/platform/win/editing/

Comment 3 by yosin@chromium.org, Jun 14 2017

Owner: yosin@chromium.org
Status: Started (was: Available)
Mark Started:
editing/inserting/edited-whitespace-1.html http://crrev.com/2937783003
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00058c119c207251ac6423b6a9eebedabdf6941f

commit 00058c119c207251ac6423b6a9eebedabdf6941f
Author: yosin <yosin@chromium.org>
Date: Wed Jun 14 06:10:54 2017

Rewrite editing/deleting/smart-editing-disabled-{mac,win}.html to utilize assert_selection()

This patch introduces "smart_editing_disabled.html" as replacement of
"editing/deleting/smart-editing-disabled-{mac,win}.html" to utilize
|assert_selection()| for ease of maintaining test case.

Because of "smart_editing_disabled.html" doesn't depend on word granularity
selection modification, all platforms yield same result.

BUG= 731756 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2935693004
Cr-Commit-Position: refs/heads/master@{#479301}

[modify] https://crrev.com/00058c119c207251ac6423b6a9eebedabdf6941f/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/417301e1059800a69d4945820cfd342a68bb9009/third_party/WebKit/LayoutTests/editing/deleting/smart-editing-disabled-mac-expected.txt
[delete] https://crrev.com/417301e1059800a69d4945820cfd342a68bb9009/third_party/WebKit/LayoutTests/editing/deleting/smart-editing-disabled-mac.html
[delete] https://crrev.com/417301e1059800a69d4945820cfd342a68bb9009/third_party/WebKit/LayoutTests/editing/deleting/smart-editing-disabled-win-expected.txt
[delete] https://crrev.com/417301e1059800a69d4945820cfd342a68bb9009/third_party/WebKit/LayoutTests/editing/deleting/smart-editing-disabled-win.html
[add] https://crrev.com/00058c119c207251ac6423b6a9eebedabdf6941f/third_party/WebKit/LayoutTests/editing/deleting/smart_editing_disabled.html
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dacd0365e96783bfccbcb9dbc4cff060e15d3fec

commit dacd0365e96783bfccbcb9dbc4cff060e15d3fec
Author: yosin <yosin@chromium.org>
Date: Wed Jun 14 07:25:49 2017

Rewrite editing/inserting/insert-composition-whitespace.html to utilize assert_selection()

This patch changes "editing/inserting/insert-composition-whitespace.html" to
utilize |assert_selection()| for ease of maintaining test case.

This patch is a preparation of the patch[1].

[1] http://crrev.com/c/527421: Fix contentEditable treatment of double spaces

BUG= 731756 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2934883004
Cr-Commit-Position: refs/heads/master@{#479316}

[modify] https://crrev.com/dacd0365e96783bfccbcb9dbc4cff060e15d3fec/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/b52f16be8c5dfc01e33afae295b5ed78c9764262/third_party/WebKit/LayoutTests/editing/inserting/insert-composition-whitespace-expected.txt
[modify] https://crrev.com/dacd0365e96783bfccbcb9dbc4cff060e15d3fec/third_party/WebKit/LayoutTests/editing/inserting/insert-composition-whitespace.html
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1942e80bb847dacadbc3b36463db5cb2098e987a

commit 1942e80bb847dacadbc3b36463db5cb2098e987a
Author: yosin <yosin@chromium.org>
Date: Wed Jun 14 07:26:19 2017

Rewrite editing/inserting/typing-at-end-of-line.html to utilize assert_selection()

This patch changes "editing/inserting/typing-at-end-of-line.html" to utilize
|assert_selection()| for ease of maintaining test case.

BUG= 731756 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2937863002
Cr-Commit-Position: refs/heads/master@{#479317}

[modify] https://crrev.com/1942e80bb847dacadbc3b36463db5cb2098e987a/third_party/WebKit/LayoutTests/editing/inserting/typing-at-end-of-line.html
[delete] https://crrev.com/dacd0365e96783bfccbcb9dbc4cff060e15d3fec/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-at-end-of-line-expected.png
[delete] https://crrev.com/dacd0365e96783bfccbcb9dbc4cff060e15d3fec/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-at-end-of-line-expected.txt
[delete] https://crrev.com/dacd0365e96783bfccbcb9dbc4cff060e15d3fec/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-at-end-of-line-expected.png
[delete] https://crrev.com/dacd0365e96783bfccbcb9dbc4cff060e15d3fec/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-at-end-of-line-expected.txt
[delete] https://crrev.com/dacd0365e96783bfccbcb9dbc4cff060e15d3fec/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-at-end-of-line-expected.png
[delete] https://crrev.com/dacd0365e96783bfccbcb9dbc4cff060e15d3fec/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-at-end-of-line-expected.txt
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33321455a76da87330f5770ce092be8a06fd5df8

commit 33321455a76da87330f5770ce092be8a06fd5df8
Author: yosin <yosin@chromium.org>
Date: Wed Jun 14 07:59:20 2017

Rewrite editing/inserting/edited-whitespace-1.html to utilize assert_selection()

This patch changes "editing/inserting/edited-whitespace-1.html" to utilize
|assert_selection()| for ease of maintaining test case.

This patch is a preparation of the patch[1].

[1] http://crrev.com/c/527421: Fix contentEditable treatment of double spaces

BUG= 731756 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2937783003
Cr-Commit-Position: refs/heads/master@{#479322}

[modify] https://crrev.com/33321455a76da87330f5770ce092be8a06fd5df8/third_party/WebKit/LayoutTests/editing/inserting/edited-whitespace-1.html
[delete] https://crrev.com/8c5e4fb1fced9af3d19e718e54e07ef8b8d2d1da/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/edited-whitespace-1-expected.png
[delete] https://crrev.com/8c5e4fb1fced9af3d19e718e54e07ef8b8d2d1da/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/edited-whitespace-1-expected.txt
[delete] https://crrev.com/8c5e4fb1fced9af3d19e718e54e07ef8b8d2d1da/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/edited-whitespace-1-expected.png
[delete] https://crrev.com/8c5e4fb1fced9af3d19e718e54e07ef8b8d2d1da/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/edited-whitespace-1-expected.txt
[delete] https://crrev.com/8c5e4fb1fced9af3d19e718e54e07ef8b8d2d1da/third_party/WebKit/LayoutTests/platform/win/editing/inserting/edited-whitespace-1-expected.png
[delete] https://crrev.com/8c5e4fb1fced9af3d19e718e54e07ef8b8d2d1da/third_party/WebKit/LayoutTests/platform/win/editing/inserting/edited-whitespace-1-expected.txt

Comment 8 by yosin@chromium.org, Jun 14 2017

Status: Fxied (was: Started)

Comment 9 by yosin@chromium.org, Jun 15 2017

Status: Fixed (was: Fxied)
►

Sign in to add a comment