New issue
Advanced search Search tips

Issue 731751 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Mac verify_order step fails in debug non-component build

Project Member Reported by rsesek@chromium.org, Jun 9 2017

Issue description

Chrome Version: fd9d71980637bf89994f61476acd7760da72612d
OS: Mac

What steps will reproduce the problem?
(1) Specify gn args:
is_component_build = false
is_debug = true
use_goma = true

(2) Build "chrome" target
(3) Get this error:

[28224/28233] ACTION //chrome:verify_chrome_framework_order(//build/toolchain/mac:clang_x64)
FAILED: obj/chrome/run_verify_chrome_framework_order.stamp 
python ../../chrome/tools/build/mac/run_verify_order.py --stamp obj/chrome/run_verify_chrome_framework_order.stamp _ChromeMain Chromium\ Framework.framework/Versions/A/Chromium\ Framework
../../chrome/tools/build/mac/verify_order: unordered symbols in Chromium Framework.framework/Versions/A/Chromium Framework:
__ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEE6__initIPcEENS_9enable_ifIXsr21__is_forward_iteratorIT_EE5valueEvE4typeES9_S9_
Traceback (most recent call last):
  File "../../chrome/tools/build/mac/run_verify_order.py", line 27, in <module>
    [ os.path.join(this_script_dir, 'verify_order') ] + unknown_args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../chrome/tools/build/mac/verify_order', '_ChromeMain', 'Chromium Framework.framework/Versions/A/Chromium Framework']' returned non-zero exit status 1


What is the expected result?
Build succeeds.

What happens instead?
Build fails.

verify_order ensures that there are no exported symbols from "Chromium Framework" (chrome_dll) except for ones in the order file: https://cs.chromium.org/chromium/src/chrome/app/framework.order. This issue only seems to occur in debug-non-component. Release builds seem fine, and we don't run verify_order in component builds.

I was able to git-bisect this down. It started May 10 and I believe this CL is what causes this to occur: https://codereview.chromium.org/2866703002

This was initially reported here: https://groups.google.com/a/google.com/forum/#!topic/chrome-mac-dev/PODn7JZAMJM


Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by mark@chromium.org, Jun 15 2017

Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
I think that  bug 721066  has the same cause.

I also think that we should back out the thing that caused this unless we have a fix, since it seems likely that it’s caused random suspicious build weirdness, and who knows what other latent problems await.

Comment 2 by jochen@chromium.org, Jun 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment