Store media experience data in content settings.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e06e83a8e6999472d4b9d6efa8ccc3b79ca8c9b7 commit e06e83a8e6999472d4b9d6efa8ccc3b79ca8c9b7 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Jul 04 16:28:17 2017 Add a MediaEngagementScore class to manage storing the score. Add a MediaEngagementScore class that manages calculating the total score as well as storing/reading the score for an origin from the content settings store. Register the setting to be synced across devices. BUG= 731750 Change-Id: I30e1ceb815c252d5f0395a8d10b905e7a6c9914b Reviewed-on: https://chromium-review.googlesource.com/529087 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#484127} [modify] https://crrev.com/e06e83a8e6999472d4b9d6efa8ccc3b79ca8c9b7/chrome/browser/BUILD.gn [add] https://crrev.com/e06e83a8e6999472d4b9d6efa8ccc3b79ca8c9b7/chrome/browser/media/media_engagement_score.cc [add] https://crrev.com/e06e83a8e6999472d4b9d6efa8ccc3b79ca8c9b7/chrome/browser/media/media_engagement_score.h [add] https://crrev.com/e06e83a8e6999472d4b9d6efa8ccc3b79ca8c9b7/chrome/browser/media/media_engagement_score_unittest.cc [modify] https://crrev.com/e06e83a8e6999472d4b9d6efa8ccc3b79ca8c9b7/chrome/test/BUILD.gn [modify] https://crrev.com/e06e83a8e6999472d4b9d6efa8ccc3b79ca8c9b7/components/content_settings/core/browser/website_settings_registry.cc [modify] https://crrev.com/e06e83a8e6999472d4b9d6efa8ccc3b79ca8c9b7/components/content_settings/core/common/content_settings_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76fd7567ab2517e5a3549b5ed172bc1986c74af5 commit 76fd7567ab2517e5a3549b5ed172bc1986c74af5 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Jul 06 09:52:15 2017 Media Engagement: Make the service store scores. Make the MediaEngagementService store scores in the context store when the MediaEngagementContentObserver detects a visit or playback of significant media. BUG= 731750 Change-Id: Iae584df3b644c5c4d6d5ea3b53105045746dcc00 Reviewed-on: https://chromium-review.googlesource.com/538774 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#484519} [modify] https://crrev.com/76fd7567ab2517e5a3549b5ed172bc1986c74af5/chrome/browser/media/media_engagement_contents_observer.cc [modify] https://crrev.com/76fd7567ab2517e5a3549b5ed172bc1986c74af5/chrome/browser/media/media_engagement_contents_observer_unittest.cc [modify] https://crrev.com/76fd7567ab2517e5a3549b5ed172bc1986c74af5/chrome/browser/media/media_engagement_score.cc [modify] https://crrev.com/76fd7567ab2517e5a3549b5ed172bc1986c74af5/chrome/browser/media/media_engagement_service.cc [modify] https://crrev.com/76fd7567ab2517e5a3549b5ed172bc1986c74af5/chrome/browser/media/media_engagement_service.h [modify] https://crrev.com/76fd7567ab2517e5a3549b5ed172bc1986c74af5/chrome/browser/media/media_engagement_service_factory.cc [add] https://crrev.com/76fd7567ab2517e5a3549b5ed172bc1986c74af5/chrome/browser/media/media_engagement_service_unittest.cc [modify] https://crrev.com/76fd7567ab2517e5a3549b5ed172bc1986c74af5/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f6ba357c883b6d4261b85dfcc0bf1c69cb46a05 commit 8f6ba357c883b6d4261b85dfcc0bf1c69cb46a05 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Jul 11 12:08:01 2017 Media Engagement: Fix muted status propagation and timer bug. The playbacks were not be recoreded correctly because muted state was not propagating through to the WebContentsObserver correctly. There was also a bug where the timer didn't have the time-delta set correctly so it was never being called. BUG= 731750 Change-Id: I2944679adbb88b9f37c1a88efa97652ff032d9b1 Reviewed-on: https://chromium-review.googlesource.com/563668 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#485599} [modify] https://crrev.com/8f6ba357c883b6d4261b85dfcc0bf1c69cb46a05/chrome/browser/media/media_engagement_contents_observer.cc [modify] https://crrev.com/8f6ba357c883b6d4261b85dfcc0bf1c69cb46a05/chrome/browser/media/media_engagement_contents_observer.h [modify] https://crrev.com/8f6ba357c883b6d4261b85dfcc0bf1c69cb46a05/chrome/browser/media/media_engagement_contents_observer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05ac3dfe945c3b9bf3b823edd3535c4560223a16 commit 05ac3dfe945c3b9bf3b823edd3535c4560223a16 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Jul 11 18:20:54 2017 Media Engagement: Remove DidFinishNavigation dcheck There is a DCHECK that checks if the timer is running when DidFinishNavigation is called. When running in Chrome this crashes the browser as it seems that the MediaStoppedPlaying calls are not being called before the navigation event. Bug: 731750 Change-Id: Ia089a1c267735e6f9dba1d271c5114c1a19d3e41 Reviewed-on: https://chromium-review.googlesource.com/567151 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#485680} [modify] https://crrev.com/05ac3dfe945c3b9bf3b823edd3535c4560223a16/chrome/browser/media/media_engagement_contents_observer.cc [modify] https://crrev.com/05ac3dfe945c3b9bf3b823edd3535c4560223a16/chrome/browser/media/media_engagement_contents_observer_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Jul 4 2017