Make sure to invoke both TriggerManager::(Start,Finish}CollectingThreatDetails methods |
||||
Issue descriptionAs per design doc: https://goo.gl/TfoY9K, section 3 (item 5), will need to hookup the StartCollectingThreatDetails() and after https://chromium-review.googlesource.com/c/525854 lands will need to call FinishCollectingThreatDetails()..
,
Jun 9 2017
,
Jun 16 2017
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/840e30ceebc2e8c39657d144f2aea24db1124256 commit 840e30ceebc2e8c39657d144f2aea24db1124256 Author: timvolodine <timvolodine@chromium.org> Date: Fri Jun 30 17:51:57 2017 Implement code for Start/Finish threat details collection in WebView. Provide calls to start/finish threat details collection in Android WebView. In particular: - implement calls to {Start,Finish}CollectThreadDetails in aw_safe_browsing_blocking_page and related code, - add crbug reference regarding HistoryService, - refactor common parts into base blocking page class. BUG= 700351 , 688629, 731747 Review-Url: https://codereview.chromium.org/2950863002 Cr-Commit-Position: refs/heads/master@{#483751} [modify] https://crrev.com/840e30ceebc2e8c39657d144f2aea24db1124256/android_webview/browser/aw_safe_browsing_blocking_page.cc [modify] https://crrev.com/840e30ceebc2e8c39657d144f2aea24db1124256/android_webview/browser/aw_safe_browsing_blocking_page.h [modify] https://crrev.com/840e30ceebc2e8c39657d144f2aea24db1124256/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc [modify] https://crrev.com/840e30ceebc2e8c39657d144f2aea24db1124256/chrome/browser/safe_browsing/safe_browsing_blocking_page.h [modify] https://crrev.com/840e30ceebc2e8c39657d144f2aea24db1124256/components/safe_browsing/base_blocking_page.cc [modify] https://crrev.com/840e30ceebc2e8c39657d144f2aea24db1124256/components/safe_browsing/base_blocking_page.h
,
Jul 11 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by timvolod...@chromium.org
, Jun 9 2017