New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731743 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jun 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Change the cell styling of ContentSuggestions

Project Member Reported by gambard@chromium.org, Jun 9 2017 
The cell styling for ContentSuggestions should be:
- Full width for Compact width x Regular height (i.e. iPhone portrait)
- Card with max width of 416 for the rest (Compact x Compact, Regular x *)
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7981a1c59d04189151bb3dac91527bd45e089a4a

commit 7981a1c59d04189151bb3dac91527bd45e089a4a
Author: gambard <gambard@chromium.org>
Date: Wed Jun 14 07:03:33 2017

Cell style follow screen compactness

The cell style, cards or full width, should follow the screen compactness.
The full width layout is only wanted when the compactness is Compact x Regular.

BUG= 731743 

Change-Id: I9555fb528672df79755d358fcd25a03088275283
Reviewed-on: https://chromium-review.googlesource.com/530790
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479311}
[modify] https://crrev.com/7981a1c59d04189151bb3dac91527bd45e089a4a/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 2 by gambard@chromium.org, Jun 14 2017

Labels: -Type-Bug Type-Feature

Comment 3 by gambard@chromium.org, Jun 14 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment