New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731742 link

Starred by 2 users
Status: Fixed
Owner:
penghuang@chromium.org
Closed: Sep 2017
Cc:
mustash-bugs@google.com
█ fsam...@chromium.org
rjkroege@chromium.org
sadrul@chromium.org
█ reve...@chromium.org
█ yoshiki@chromium.org
sky@chromium.org
varkha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 672961



Sign in to add a comment

Use one CompositorFrameSink per exo shell surface

Project Member Reported by penghuang@chromium.org, Jun 9 2017 
Currently, exo creates CompositorFrameSink for every surface. It is not
an ideal implementation. We will switch to use one CompositorFrameSink
per exo shell surface.

Comment 1 by penghuang@chromium.org, Jun 9 2017

Cc: mustash-bugs@google.com
Labels: Proj-Mustash

Comment 2 by varkha@chromium.org, Jun 9 2017

Labels: -Pri-3 M-61 OS-Chrome Pri-2
Some context was discussed here - https://docs.google.com/document/d/1PDLPmHb_-afv6hKbZKwKjK6TnSPj5H7hnVokmToOsJ8

Comment 3 by varkha@chromium.org, Jun 9 2017

Blocking: 672961
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7abd4c15fe6096a0a06a06fa5d42dfd6b791968

commit f7abd4c15fe6096a0a06a06fa5d42dfd6b791968
Author: Peng Huang <penghuang@google.com>
Date: Tue Jun 20 21:57:50 2017

exo: Remove some methods which are not useful.

In https://codereview.chromium.org/2868473002, we create
CompositorFrameSink from aura::Window, and the CompositorFrameSink
controls when to allocate a new cc::Surface, and exo doesn't explicitly
create new cc::Surface anymore. So some methods related to creating new
surface are not useful anymore, so remove them.


Bug:  731742 
Change-Id: If8ce2eda0143a7ce394c95d4d87fefbeebe2ebf1
Reviewed-on: https://chromium-review.googlesource.com/541456
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480976}
[modify] https://crrev.com/f7abd4c15fe6096a0a06a06fa5d42dfd6b791968/components/exo/notification_surface.cc
[modify] https://crrev.com/f7abd4c15fe6096a0a06a06fa5d42dfd6b791968/components/exo/pointer.cc
[modify] https://crrev.com/f7abd4c15fe6096a0a06a06fa5d42dfd6b791968/components/exo/shell_surface.cc
[modify] https://crrev.com/f7abd4c15fe6096a0a06a06fa5d42dfd6b791968/components/exo/sub_surface.cc
[modify] https://crrev.com/f7abd4c15fe6096a0a06a06fa5d42dfd6b791968/components/exo/surface.cc
[modify] https://crrev.com/f7abd4c15fe6096a0a06a06fa5d42dfd6b791968/components/exo/surface.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b07b0652373058bd09f093879f5e66d079793572

commit b07b0652373058bd09f093879f5e66d079793572
Author: Peng Huang <penghuang@google.com>
Date: Wed Jun 28 11:21:14 2017

exo: Add SurfaceTreeHost

The SurfaceTreeHost is for hosting a exo surface tree in
an aura::Window. And the users (ShellSurface, Pointer and
NotificationSurface) of SurfaceTreeHost just need embed the
aura::Window in SurfaceTreeHost.

In future, we will only have one CompositorFrameSink per
exo toplevel window, so the SurfaceTreeHost will manage
the CompositorFrameSink and generate CompositorFrame for
the surface tree in it.

Bug:  731742 
Change-Id: I8621d7cde2c1142de97c50f1952384937dbd882d
Reviewed-on: https://chromium-review.googlesource.com/541061
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482943}
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/BUILD.gn
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/notification_surface.cc
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/notification_surface.h
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/pointer.cc
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/pointer.h
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/shell_surface.cc
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/shell_surface.h
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/surface.h
[add] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/surface_tree_host.cc
[add] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/components/exo/surface_tree_host.h
[modify] https://crrev.com/b07b0652373058bd09f093879f5e66d079793572/ui/arc/notification/arc_notification_surface_impl.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f2416490dad11ff130aaaba5285f13af1f6ed62

commit 5f2416490dad11ff130aaaba5285f13af1f6ed62
Author: Peng Huang <penghuang@google.com>
Date: Wed Jun 28 20:32:32 2017

exo: Allocate the buffer resource id from LayerFrameSinkHolder.

In future, all surfaces in a surface tree will share one
exo::LayerFrameSinkHolder and all buffers in this tree should
have unique resource id, so we have to move the id allocation
code from exo::Surface to exo::LayerFrameSinkHolder.

Bug:  731742 
Change-Id: I3e5746995ec61305ddc616fba8171d2a6ae116fb
Reviewed-on: https://chromium-review.googlesource.com/550438
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483118}
[modify] https://crrev.com/5f2416490dad11ff130aaaba5285f13af1f6ed62/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/5f2416490dad11ff130aaaba5285f13af1f6ed62/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/5f2416490dad11ff130aaaba5285f13af1f6ed62/components/exo/surface.cc
[modify] https://crrev.com/5f2416490dad11ff130aaaba5285f13af1f6ed62/components/exo/surface.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f933e8072baea04682406b524b39b46470e882b

commit 5f933e8072baea04682406b524b39b46470e882b
Author: Peng Huang <penghuang@google.com>
Date: Fri Jul 14 17:12:07 2017

exo: Use one LayerTreeFrameSink per toplevel window

Having one LayerTreeFrameSink for every sub-surface
causes synchronizing problem between sub-surfaces, so
we decide to only have one LayerTreeFrameSink per
toplevel window.

Bug:  731742 
Change-Id: I6f3e09c33f6f98aab281ce2fab032f9df29f1e7d
Reviewed-on: https://chromium-review.googlesource.com/552719
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486788}
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/buffer.cc
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/buffer.h
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/buffer_unittest.cc
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/shell_surface.cc
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/shell_surface.h
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/sub_surface.cc
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/sub_surface_unittest.cc
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/surface.cc
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/surface.h
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/surface_tree_host.cc
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/surface_tree_host.h
[modify] https://crrev.com/5f933e8072baea04682406b524b39b46470e882b/components/exo/surface_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f19a78b4e3f0a3242bec6938ae55f49f74fa210

commit 4f19a78b4e3f0a3242bec6938ae55f49f74fa210
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Tue Jul 18 05:28:51 2017

Revert "exo: Use one LayerTreeFrameSink per toplevel window"

This reverts commit 5f933e8072baea04682406b524b39b46470e882b.

Reason for revert:  crbug.com/744235  All ARC apps are broken (black screen.)

Original change's description:
> exo: Use one LayerTreeFrameSink per toplevel window
> 
> Having one LayerTreeFrameSink for every sub-surface
> causes synchronizing problem between sub-surfaces, so
> we decide to only have one LayerTreeFrameSink per
> toplevel window.
> 
> Bug:  731742 
> Change-Id: I6f3e09c33f6f98aab281ce2fab032f9df29f1e7d
> Reviewed-on: https://chromium-review.googlesource.com/552719
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486788}

TBR=penghuang@chromium.org,reveman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  731742 
Change-Id: Id6dabf41959396ee20b0e87e88feb9a432f41fb4
Reviewed-on: https://chromium-review.googlesource.com/575294
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487392}
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/buffer.cc
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/buffer.h
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/buffer_unittest.cc
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/shell_surface.cc
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/shell_surface.h
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/sub_surface.cc
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/sub_surface_unittest.cc
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/surface.cc
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/surface.h
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/surface_tree_host.cc
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/surface_tree_host.h
[modify] https://crrev.com/4f19a78b4e3f0a3242bec6938ae55f49f74fa210/components/exo/surface_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 18 2017

Labels: merge-merged-3159
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd68b7b4b4b23dc93a5f45a27a653748371e9420

commit bd68b7b4b4b23dc93a5f45a27a653748371e9420
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Tue Jul 18 18:10:42 2017

Revert "exo: Use one LayerTreeFrameSink per toplevel window"

This reverts commit 5f933e8072baea04682406b524b39b46470e882b.

Reason for revert:  crbug.com/744235  All ARC apps are broken (black screen.)

Original change's description:
> exo: Use one LayerTreeFrameSink per toplevel window
>
> Having one LayerTreeFrameSink for every sub-surface
> causes synchronizing problem between sub-surfaces, so
> we decide to only have one LayerTreeFrameSink per
> toplevel window.
>
> Bug:  731742 
> Change-Id: I6f3e09c33f6f98aab281ce2fab032f9df29f1e7d
> Reviewed-on: https://chromium-review.googlesource.com/552719
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486788}

TBR=penghuang@chromium.org,reveman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

(cherry picked from commit 4f19a78b4e3f0a3242bec6938ae55f49f74fa210)

Bug:  731742 
Change-Id: Id6dabf41959396ee20b0e87e88feb9a432f41fb4
Reviewed-on: https://chromium-review.googlesource.com/575294
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#487392}
Reviewed-on: https://chromium-review.googlesource.com/576274
Reviewed-by: Josafat Garcia <josafat@chromium.org>
Cr-Commit-Position: refs/branch-heads/3159@{#8}
Cr-Branched-From: c421374e09e082113bb53970f2cf650f2130c61a-refs/heads/master@{#486995}
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/buffer.cc
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/buffer.h
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/buffer_unittest.cc
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/shell_surface.cc
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/shell_surface.h
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/sub_surface.cc
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/sub_surface_unittest.cc
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/surface.cc
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/surface.h
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/surface_tree_host.cc
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/surface_tree_host.h
[modify] https://crrev.com/bd68b7b4b4b23dc93a5f45a27a653748371e9420/components/exo/surface_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/583c9dc6aebca1961320efab48bea42ce2e78fd4

commit 583c9dc6aebca1961320efab48bea42ce2e78fd4
Author: Peng Huang <penghuang@google.com>
Date: Thu Jul 27 23:38:28 2017

exo: Use one LayerTreeFrameSink per toplevel window

Having one LayerTreeFrameSink for every sub-surface
causes synchronizing problem between sub-surfaces, so
we decide to only have one LayerTreeFrameSink per
toplevel window.

Bug:  731742 
Change-Id: Iacf0cb15f5dba8cb86bc2b7bafb21ac9d54f0bcb
Reviewed-on: https://chromium-review.googlesource.com/582932
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490115}
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/buffer.cc
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/buffer.h
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/buffer_unittest.cc
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/shell_surface.cc
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/shell_surface.h
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/sub_surface.cc
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/sub_surface_unittest.cc
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/surface.cc
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/surface.h
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/surface_tree_host.cc
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/surface_tree_host.h
[modify] https://crrev.com/583c9dc6aebca1961320efab48bea42ce2e78fd4/components/exo/surface_unittest.cc

Comment 11 by osh...@chromium.org, Aug 8 2017 

Hi, can you merge above CL to 61?

Comment 12 by penghuang@chromium.org, Aug 9 2017

Cc: yoshiki@chromium.org
Why we need merge above CL to 61? I think both M & N can work in M61 with or without this CL. However above CL causes several notification related regressions. Those regressions have been fixed in Tot. To merge above CL, we need also merge below CLs. And I am afraid there may have more issues which are not found yet. So I feel it is not safe to merge the CL to M61.


https://chromium-review.googlesource.com/604815
https://chromium-review.googlesource.com/595349
Maybe more.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceb3d80c190292ad4d4f448aac10770eaca13c73

commit ceb3d80c190292ad4d4f448aac10770eaca13c73
Author: Peng Huang <penghuang@google.com>
Date: Wed Aug 09 17:24:30 2017

exo: Add a wayland test program for testing subsurface features.

Bug:  731742 
Change-Id: Id9f3bd643f9d6354be53002fa8e2eb749efc7fff
Reviewed-on: https://chromium-review.googlesource.com/540418
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493038}
[modify] https://crrev.com/ceb3d80c190292ad4d4f448aac10770eaca13c73/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/ceb3d80c190292ad4d4f448aac10770eaca13c73/components/exo/wayland/clients/client_base.cc
[modify] https://crrev.com/ceb3d80c190292ad4d4f448aac10770eaca13c73/components/exo/wayland/clients/client_base.h
[modify] https://crrev.com/ceb3d80c190292ad4d4f448aac10770eaca13c73/components/exo/wayland/clients/client_helper.cc
[modify] https://crrev.com/ceb3d80c190292ad4d4f448aac10770eaca13c73/components/exo/wayland/clients/client_helper.h
[modify] https://crrev.com/ceb3d80c190292ad4d4f448aac10770eaca13c73/components/exo/wayland/clients/rects.cc
[modify] https://crrev.com/ceb3d80c190292ad4d4f448aac10770eaca13c73/components/exo/wayland/clients/simple.cc
[add] https://crrev.com/ceb3d80c190292ad4d4f448aac10770eaca13c73/components/exo/wayland/clients/subsurface.cc

Comment 14 by mtomasz@chromium.org, Aug 14 2017 

The CL in #10 also causes regressions on kevin when moving a window. The shadows are now out of sync with the main surface. See b/64655630.
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4c2a921e4a78c77577b17db1a70816799eb23e9

commit c4c2a921e4a78c77577b17db1a70816799eb23e9
Author: Peng Huang <penghuang@google.com>
Date: Tue Aug 15 19:50:58 2017

exo: Allocate new surface when shadow bounds is changed.

For synchronizing shadow and ARC++ window, we allocate
a new surface when shadow bounds is changed.

Test: Test with ARC++ apps.
Bug:  731742 
Change-Id: Ia9986c18d906b9b01bc8dd6bb32c9f284107520b
Reviewed-on: https://chromium-review.googlesource.com/614064
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494507}
[modify] https://crrev.com/c4c2a921e4a78c77577b17db1a70816799eb23e9/components/exo/shell_surface.cc
[modify] https://crrev.com/c4c2a921e4a78c77577b17db1a70816799eb23e9/components/exo/shell_surface.h
[modify] https://crrev.com/c4c2a921e4a78c77577b17db1a70816799eb23e9/ui/aura/local/layer_tree_frame_sink_local.cc
[modify] https://crrev.com/c4c2a921e4a78c77577b17db1a70816799eb23e9/ui/aura/local/layer_tree_frame_sink_local.h

Comment 16 by mtomasz@chromium.org, Aug 16 2017 

Can we merge #15 to 61?

Comment 17 by domlasko...@chromium.org, Aug 21 2017 

Please hold off merging to M61. The CL in #10 breaks multi-display support in ARC. I have a tentative client-side fix, but it's a bit risky for M61. See b/64893967 for details.
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76f5fd03ac44a9d30c9f62094d11377c2bc607c5

commit 76f5fd03ac44a9d30c9f62094d11377c2bc607c5
Author: Peng Huang <penghuang@google.com>
Date: Fri Sep 01 00:59:39 2017

exo: fix scale problem in mushrome

In muschrome, exo doesn't render correctly if the device scale factor is
not 1. In exo, surface's size is in dip, but the size of viz::Surface is
in pixel. So we need scale the exo surfaces when we composite them to a
viz::Surface.

Bug:  731742 
Change-Id: I4c86e5d53053b36a1889de7afb425aa68017a2b6
Reviewed-on: https://chromium-review.googlesource.com/616841
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499088}
[modify] https://crrev.com/76f5fd03ac44a9d30c9f62094d11377c2bc607c5/components/exo/surface.cc
[modify] https://crrev.com/76f5fd03ac44a9d30c9f62094d11377c2bc607c5/components/exo/surface.h
[modify] https://crrev.com/76f5fd03ac44a9d30c9f62094d11377c2bc607c5/components/exo/surface_tree_host.cc
[modify] https://crrev.com/76f5fd03ac44a9d30c9f62094d11377c2bc607c5/components/exo/surface_tree_host.h
[modify] https://crrev.com/76f5fd03ac44a9d30c9f62094d11377c2bc607c5/components/exo/surface_unittest.cc

Comment 19 by penghuang@chromium.org, Sep 1 2017

Status: Fixed (was: Started)

Comment 20 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 21 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Comment 22 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService
►

Sign in to add a comment