New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731735 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Duplicate notification with same id on MAC OS X

Reported by r...@altirnao.com, Jun 9 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36

Steps to reproduce the problem:
1. Load provided extension into a Chrome 59 on a MacOS
2. Observe the notifications displayed

What is the expected behavior?
- Only one basic notification should be displayed with "Basic Title" as title and "Basic Message" as message
- The notification content should be updated every one second with "Progress Title" as title and "Progress Message" as message and a progress percentage
- The notification should be automatically closed once 100% is reached

What went wrong?
- A second notification appears after the first call to 'chrome.notifications.update'
- Each notification content is randomly updated (as both notification have the same id I presume)
- Calling 'chrome.notifications.clear' has no effect (both notifications remains opened)
- Closing one of the notification with the 'x', also close the other notification

Did this work before? Yes M58 (before native notifications on Mac OS were introduced)

Does this work in other browsers? N/A

Chrome version: 59.0.3071.86  Channel: stable
OS Version: Sierra 10.12.5
Flash Version: 

It appears that updating the 'type' of the notification is responsible for this behavior. If the 'type' was 'progress' when the notification was created, only one notification is displayed and updated
 
macos-notifications-issue.zip
6.8 KB Download
Screen Shot 2017-06-09 at 16.43.51.png
305 KB View Download
Screen Shot 2017-06-09 at 16.43.52.png
273 KB View Download
Screen Shot 2017-06-09 at 16.43.59.png
268 KB View Download
Screen Shot 2017-06-09 at 16.44.02.png
280 KB View Download
Components: UI>Notifications
Cc: peter@chromium.org devlin@chromium.org
Owner: miguelg@chromium.org
Status: Assigned (was: Unconfirmed)
Good catch this is in fact a real bug. 

Before I propose a fix I'd like to clarify if this is something that can happen from the API point of view.
Devlin:  Is upgrading a notification from simple to progress supposed to be possible? Are downgrades also possible then?

Comment 3 by abwic...@gmail.com, Jun 12 2017

Not sure if related, but I noticed that there are two entries for Chrome in the Notifications system preferences. 
Screen Shot 2017-06-12 at 10.09.18 AM.png
144 KB View Download

Comment 4 by peter@chromium.org, Jun 13 2017

> Is upgrading a notification from simple to progress supposed to be possible? Are downgrades also possible then?

Yes.

> Not sure if related, but I noticed that there are two entries for Chrome in the Notifications system preferences.

Correct, because we display different kinds of notifications (both banners and alerts) whereas the system only allows an individual entry to display either.
Cc: shrike@chromium.org
Owner: lgrey@chromium.org
lgrey@ (currently OOO) - can you take a look at this one as well?

Comment 6 by j...@e9data.com, Aug 9 2017

Hello, I am experiencing the second issue, duplicate entries for Chrome in Mac System Preferences / Notifications settings.  MacBook Air, macOS Sierra 10.12.6, Google Chrome Version 60.0.3112.90 (Official Build) (64-bit).

FYI, I had duplicate entries for iTunes in notifications preferences as well.  By executing the following in Terminal I was able to eliminate iTunes, but Chrome is still duplicated.

cd $(getconf DARWIN_USER_DIR)com.apple.notificationcenter/db
move db db.temp


Comment 7 by lgrey@chromium.org, Sep 22 2017

john@e9data.com, per comment 5, the multiple entries in System Preferences should be intentional. Are you getting duplicate notifications as well?

Comment 8 by lgrey@chromium.org, Sep 22 2017

Cc: rdevlin....@chromium.org
rdevlin.cronin@, what do you think re: the question in comment 2?

Comment 9 by peter@chromium.org, Sep 25 2017

fwiw I already answered that in #c3 -- yes, these are possible.

Notifications sharing an ID should replace each other. The problem is that by having separate listings for banners and alerts, they effectively have different "queues". Moving a notification from one to the other will thus result in it showing twice.

One solution might be to issue an explicit close on the other type? I.e. a banner with id "foobar" is being shown, we show it, and then try to close an alert with id "foobar". It's a hack and doesn't give us clean replacement, but we're not going to be able to get that anyway..

Comment 10 by oty...@gmail.com, Jan 17 2018

Look at the app "ChronoSync" in the Notification list. They also have two entries. The subtle differences in the app icon and the title of the notification entries helps distinguish which entry is which and what their purpose is. (see attached).

In case of Chrome, the issue is really not that there are two entries. They issue is that they have the same icons and titles, therefore it appears to the user as if it were a bug. And so it results in endless amount of threads floating around about it. If the entries were clearly labeled and possibly had subtle differences in the icon, people would not mistaken it as a result of a possible "issue". And so, developers would not have to waste their time creating bug reports and answering them.
ChronoSync.png
294 KB View Download

Comment 11 by lgrey@chromium.org, Jan 18 2018

That's not exactly the same thing. I don't have that application installed, but I would guess that ChronoSync Scheduler is a helper binary, hence the different name and icon. Both entries display banners and not alerts.
This is silly. Which of the two entries in Notifications is supposed to be displaying Alerts, and which one is supposed to be displaying Banners? And why does this situation even exist?

I ask because I've changed settings under both entries.

These two entries at LEAST need unique names.

Perhaps the second set of Notifications can be spun off to be handled by a do-little binary with a distinct name, which then communicates the desired Notification settings to Chrome?
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
***UI Mass triage***

Adding labels for expert review.

Able to reproduce the issue on Mac OS X 10.13 using Canary #72.0.3617.0

Sign in to add a comment