New issue
Advanced search Search tips

Issue 731731 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

can't hard-code skp binarys in layout tests

Project Member Reported by reed@google.com, Jun 9 2017

Issue description

Since the skp binary format can change over-time, it is fragile to embed it directly (as base-64 text) in a layout test. Need a more dynamic way to test for empty pictures...

Supressing inspector-protocol/layers/paint-profiler-load-empty.html
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bd38e83d4f360d2a1258d0eaa143de826f2062a

commit 0bd38e83d4f360d2a1258d0eaa143de826f2062a
Author: reed <reed@google.com>
Date: Fri Jun 09 15:36:33 2017

suppress fragile test for binary skp

BUG=731731

NOTRY=True

Review-Url: https://codereview.chromium.org/2925273006
Cr-Commit-Position: refs/heads/master@{#478288}

[modify] https://crrev.com/0bd38e83d4f360d2a1258d0eaa143de826f2062a/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by sheriffbot@chromium.org, Jul 13 2017

Labels: Hotlist-Google
Owner: caseq@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment