New issue
Advanced search Search tips

Issue 731725 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
nzolghadr@chromium.org
dtapu...@chromium.org
eirage@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

TouchPoint.radius_x/y shouldn't be equal to PointerEvent.width/height

Project Member Reported by mustaq@chromium.org, Jun 9 2017 
Looks like I missed this during the initial plumbing of PointerEvents.

Although TouchEvent's touch ellipse is not the same as PointerEvent's touch rectangles, their extents along x & y dimensions are directly comparable.

So any radius of the ellipse should exactly equal to half the corresponding extent of the rectangle (assuming non-rotated touch geometry).

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/events/PointerEventFactory.cpp?rcl=85888e0c9acd6cf6b04a21f78436b5e9b85f7251&l=129

We need to fix this, and add a test too.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac6d1582824815fe59757189b0377773bb055375

commit ac6d1582824815fe59757189b0377773bb055375
Author: Yeol <peary2@gmail.com>
Date: Thu Dec 07 16:46:18 2017

Modified PointerEvent.width/height to double of TouchPoint.radius_x/y.

TouchPoint radius of the ellipse should exactly equal to half
the corresponding extent of the rectangle.
assuming non-rotated touch geometry.

Bug:  731725 
Change-Id: Ibf19c867549f13676afbc6cd0d504850fb415159
Reviewed-on: https://chromium-review.googlesource.com/762827
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522448}
[modify] https://crrev.com/ac6d1582824815fe59757189b0377773bb055375/third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-event-properties.html
[modify] https://crrev.com/ac6d1582824815fe59757189b0377773bb055375/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/ac6d1582824815fe59757189b0377773bb055375/third_party/WebKit/Source/platform/WebPointerEvent.cpp

Comment 2 by mustaq@chromium.org, Jan 29 2018

Status: Fixed (was: Available)
Thanks peary2@gmail.com for fixing this.
►

Sign in to add a comment