Convert TabUsageRecorder to use WebState instead of Tab |
||||
Issue descriptionTo allow sharing with new architecture, convert TabUsageRecorder to use WebState instead of Tab. Looking at TabUsageRecorderTest, the only information stored in Tab not yet accessible in WebState is whether the Tab is a pre-render Tab or not. This should be moved to a TabHelper (pre-render tab helper).
,
Aug 22 2017
,
Aug 25 2017
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/592ae32947606f96fa9529342b4e3a6b6b7ada3c commit 592ae32947606f96fa9529342b4e3a6b6b7ada3c Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Aug 25 16:15:58 2017 TabUsageRecorder register with NSNotificationCenter. Change TabUsageRecorder to register for NSNotificationCenter's notification instead of having TabModel forward them. Bug: 731724 Change-Id: I6a2a834e991f32fce6292e52e4b4a4f1320055f5 Reviewed-on: https://chromium-review.googlesource.com/635845 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#497430} [modify] https://crrev.com/592ae32947606f96fa9529342b4e3a6b6b7ada3c/ios/chrome/browser/metrics/tab_usage_recorder.h [modify] https://crrev.com/592ae32947606f96fa9529342b4e3a6b6b7ada3c/ios/chrome/browser/metrics/tab_usage_recorder.mm [modify] https://crrev.com/592ae32947606f96fa9529342b4e3a6b6b7ada3c/ios/chrome/browser/tabs/tab_model.mm
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba3d61abd72c83f6c5d206f49da5d10fa9671661 commit ba3d61abd72c83f6c5d206f49da5d10fa9671661 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Aug 31 08:20:33 2017 TabUsageRecorder tracks WebState navigation events. Remove code from Tab forwarding WebState navigation events by directly instantiating WebStateObserver from TabUsageRecorder. Add unit tests for Tab.StateAtRendererTermination histogram. Bug: 731724 Change-Id: I22e51c851635f43925cf95196a2c56fd2d343472 Reviewed-on: https://chromium-review.googlesource.com/641492 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#498785} [modify] https://crrev.com/ba3d61abd72c83f6c5d206f49da5d10fa9671661/ios/chrome/browser/metrics/tab_usage_recorder.h [modify] https://crrev.com/ba3d61abd72c83f6c5d206f49da5d10fa9671661/ios/chrome/browser/metrics/tab_usage_recorder.mm [modify] https://crrev.com/ba3d61abd72c83f6c5d206f49da5d10fa9671661/ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm [modify] https://crrev.com/ba3d61abd72c83f6c5d206f49da5d10fa9671661/ios/chrome/browser/tabs/tab.mm
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b5ff13c4c094ffdd82fa019448ac2d57f406d09 commit 8b5ff13c4c094ffdd82fa019448ac2d57f406d09 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Oct 13 16:49:18 2017 Rename variables in TabUsageRecorder. TabUsageRecorder variable and data member are now WebStates instead of Tabs, so rename them accordingly. Bug: 731724 Change-Id: If1b76faa1782c1ddb9e2bcbcc69c698f56954782 Reviewed-on: https://chromium-review.googlesource.com/718751 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#508725} [modify] https://crrev.com/8b5ff13c4c094ffdd82fa019448ac2d57f406d09/ios/chrome/browser/metrics/tab_usage_recorder.h [modify] https://crrev.com/8b5ff13c4c094ffdd82fa019448ac2d57f406d09/ios/chrome/browser/metrics/tab_usage_recorder.mm
,
Oct 19 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by eugene...@chromium.org
, Jul 6 2017