New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731721 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Implement details UI for quiet Safe browsing interstitials for WebView

Project Member Reported by edwardjung@chromium.org, Jun 9 2017

Issue description

For V2, implement the details link, details info and proceed link for the medium sized interstitials.

Spec:
https://docs.google.com/a/google.com/presentation/d/122QYhQos6Sw2KL18H9liPF0tVtus8v009W6Tyo6jEYU/edit?usp=sharing
 
Status: Started (was: Assigned)
Blocking: 732554
Blocking: -732554
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd53cb080c712e419d2a1a3f753576f4de4342a5

commit bd53cb080c712e419d2a1a3f753576f4de4342a5
Author: edwardjung <edwardjung@chromium.org>
Date: Tue Jun 13 09:39:15 2017

Implement V2 design for quiet safe browsing interstitial

+ Add details link and details content
+ Implement proceed link.

BUG= 731721 

Review-Url: https://codereview.chromium.org/2930043002
Cr-Commit-Position: refs/heads/master@{#478951}

[modify] https://crrev.com/bd53cb080c712e419d2a1a3f753576f4de4342a5/components/security_interstitials/core/browser/resources/interstitial_common.js
[modify] https://crrev.com/bd53cb080c712e419d2a1a3f753576f4de4342a5/components/security_interstitials/core/browser/resources/interstitial_large.js
[modify] https://crrev.com/bd53cb080c712e419d2a1a3f753576f4de4342a5/components/security_interstitials/core/browser/resources/interstitial_mobile_nav.js
[modify] https://crrev.com/bd53cb080c712e419d2a1a3f753576f4de4342a5/components/security_interstitials/core/browser/resources/interstitial_webview_quiet.css
[modify] https://crrev.com/bd53cb080c712e419d2a1a3f753576f4de4342a5/components/security_interstitials/core/browser/resources/interstitial_webview_quiet.html
[modify] https://crrev.com/bd53cb080c712e419d2a1a3f753576f4de4342a5/components/security_interstitials/core/browser/resources/interstitial_webview_quiet.js
[modify] https://crrev.com/bd53cb080c712e419d2a1a3f753576f4de4342a5/components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
[modify] https://crrev.com/bd53cb080c712e419d2a1a3f753576f4de4342a5/components/security_interstitials_strings.grdp

Status: Fixed (was: Started)
Screenshots from Nate:
https://drive.google.com/drive/folders/0B6dOsuQZDwrMQ0VFYWJybVFvWDQ?usp=sharing


Labels: WebView-SafeBrowsing

Sign in to add a comment