Chromoting breaks the build |
||||||||||
Issue description
Last known working version: #467258 = 5f758d2372
First known broken version: #474258 = a61ab21892
Steps to reproduce:
1. Set GN args:
is_component_build = true
is_debug = false
dcheck_always_on = true
enable_nacl = false
remove_webcore_debug_symbols = true
use_goma = true
target_os = "chromeos"
2. Run ninja with default target.
[11244/11362] CXX obj/remoting/host/linux/remoting_native_messaging_host/me2me_native_messaging_host_main.o
FAILED: obj/remoting/host/linux/remoting_native_messaging_host/me2me_native_messaging_host_main.o
/usr/local/google/home/tnagel/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/remoting/host/linux/remoting_native_messaging_host/me2me_native_messaging_host_main.o.d -DVERSION=60.0.3110.0 -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DDISABLE_NACL -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"303369-1\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DANGLE_ENABLE_RELEASE_ASSERTS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DPROTOBUF_USE_DLLS -DBORINGSSL_SHARED_LIBRARY -I../.. -Igen -I../../third_party/libwebp -I../../third_party/khronos -I../../gpu -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nss -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nspr -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -m64 -march=x86-64 -pthread -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-shift-negative-value -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wno-header-guard -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -c ../../remoting/host/setup/me2me_native_messaging_host_main.cc -o obj/remoting/host/linux/remoting_native_messaging_host/me2me_native_messaging_host_main.o
../../remoting/host/setup/me2me_native_messaging_host_main.cc:48:10: fatal error: 'glib-object.h' file not found
#include <glib-object.h>
^~~~~~~~~~~~~~~
,
Jun 12 2017
It looks like this was broken by commit 03964155ee6907576b1b1ece4db4b477751e4933: chromeos: make ozone the default X11 is no longer used on any machines and X11 for chromeos will soon be removed entirely. So, switch the default for chromeos to use_ozone. All the builders explicitly specify what config they want, so there shouldn't be any changes needed there. BUG= 722539 TEST=none R=brettw@chromium.org Review-Url: https://codereview.chromium.org/2895523002 Cr-Commit-Position: refs/heads/master@{#473237} It looks like we're including a header on OS_LINUX that should not be included for OS_CHROMEOS.
,
Jun 12 2017
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/759ec5f572a9f9b9ad8ba2262c9fbefb321df0fd commit 759ec5f572a9f9b9ad8ba2262c9fbefb321df0fd Author: jamiewalch <jamiewalch@chromium.org> Date: Mon Jun 12 23:49:42 2017 Fix ChromeOS build. BUG= 731711 Review-Url: https://codereview.chromium.org/2928423003 Cr-Commit-Position: refs/heads/master@{#478824} [modify] https://crrev.com/759ec5f572a9f9b9ad8ba2262c9fbefb321df0fd/remoting/host/setup/me2me_native_messaging_host_main.cc
,
Jun 12 2017
tnagel, this should now be fixed; does it need to be merged to any branches?
,
Jun 13 2017
Many thanks! No idea whether merge is required.
,
Jun 13 2017
It looks like the CL that broke this landed in M60, so I'm requesting a merge of the fix to that branch too.
,
Jun 13 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 14 2017
approved for M60
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9131c0bb5371c196d3d3eb7c0418656d7f2a782e commit 9131c0bb5371c196d3d3eb7c0418656d7f2a782e Author: Jamie Walch <jamiewalch@chromium.org> Date: Wed Jun 14 01:01:02 2017 Fix ChromeOS build. BUG= 731711 Review-Url: https://codereview.chromium.org/2928423003 Cr-Original-Commit-Position: refs/heads/master@{#478824} Review-Url: https://codereview.chromium.org/2933303003 . Cr-Commit-Position: refs/branch-heads/3112@{#332} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/9131c0bb5371c196d3d3eb7c0418656d7f2a782e/remoting/host/setup/me2me_native_messaging_host_main.cc
,
Jan 22 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tnagel@chromium.org
, Jun 12 2017