New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731698 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----

Blocking:
issue 726192



Sign in to add a comment

Add RemoteSuggestionsFetcher interface.

Project Member Reported by vitaliii@chromium.org, Jun 9 2017

Issue description

This is needed to mock RemoteSuggestionsFetcher in RemoteSuggestionsProviderImpl tests.
 
Blocking: 726192
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3f276cf3b3b1198fd2219f236c02b9480d50108

commit e3f276cf3b3b1198fd2219f236c02b9480d50108
Author: Vitalii Iarko <vitaliii@chromium.org>
Date: Tue Jun 13 08:16:04 2017

[NTP::Articles::Cleanup] Add RemoteSuggestionsFetcher interface.

This CL adds RemoteSuggestionsFetcher interface. The existing
implementation is renamed to RemoteSuggestionsFetcherImpl. Some includes
are removed and some are added.

This is needed to mock RemoteSuggestionsFetcher in
RemoteSuggestionsProviderImpl tests.

Bug:  731698 
Change-Id: Ib688de74e519d8bdb81be1d7d007c8305ae6361a
Reviewed-on: https://chromium-review.googlesource.com/529245
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478930}
[modify] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/components/ntp_snippets/BUILD.gn
[modify] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/components/ntp_snippets/remote/json_to_categories.h
[modify] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/components/ntp_snippets/remote/remote_suggestions_fetcher.cc
[modify] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/components/ntp_snippets/remote/remote_suggestions_fetcher.h
[add] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.cc
[add] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.h
[rename] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/components/ntp_snippets/remote/remote_suggestions_fetcher_impl_unittest.cc
[modify] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
[modify] https://crrev.com/e3f276cf3b3b1198fd2219f236c02b9480d50108/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

Status: Fixed (was: Started)

Sign in to add a comment