Ensure that chromium never depends on extensions when enable_extensions=false
Reported by
hu...@opera.com,
Jun 9 2017
|
|||
Issue description
We should not build //extensions if enable_extensions=false.
To ensure that no BUILD.gn file within chromium mistakenly depends on something in //extensions, we need to add an assert like:
assert(enable_extensions,
"Cannot depend on extensions because enable_extensions=false.")
to all /extensions/*/BUILD.gn files.
,
Jun 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 16
You'll notice most of extensions/common/BUILD.gn is inside an if (enable_extensions) block. "common_constants" is the only source_set that is outside of it. This was my doing. It was really hard to get common_constants to be extensions only, so I gave up and called it a day. I left tons of asserts and #errors in other extensions code. It would be really hard for someone to accidentally enable extensions. I would recommend making a quick attempt to see if fixing this is actually feasible. If it is not, close this and remove the two TODOs referencing this bug.
,
Nov 16
(Updating labels and status) It also looks like there might be a bit of cleanup possible in c/b/ui, and maybe a few other smaller directories. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dpranke@chromium.org
, Jun 9 2017