Regression: Unnecessary Info bar of theme is seen after signing in to chrome again
Reported by
vku...@etouch.net,
Jun 9 2017
|
|||
Issue descriptionChrome Version:61.0.3124.4 (Official Build) 2ccba3fd9c04d6ca967808d2fbb9aadbbda5fb6f-refs/branch-heads/3124@{#6} 32/64 bit OS: Windows(7,8,10), Linux(14.04 LTS)Mac (10.12.3,10.11.6) URL: https://chrome.google.com/webstore/detail/%D0%BB%D0%B5%D1%82%D1%8F%D1%89%D0%B8%D0%B5-%D0%BA%D1%80%D0%B0%D1%81%D0%BA%D0%B8/iaddkdiibkddhdbcmmplkhcpgeinggfo?hl=en 1. Launch Chrome and sign in to chrome account with valid credentials. 2. Apply ‘Theme’ using above url and click on close icon ‘x’ of Info bar 3. Sign out from Chrome (with checked ‘Also remove data from device’). 4. Again sign in to chrome with same credentials and observe Actual : Unnecessary Info bar is seen after signing in to chrome again Expected : Info bar should not be seen after signing in to chrome again This is a regression issue broken in M-61, will soon update the bisect info Good Build : 61.0.3118.0 Bad Build : 61.0.3119.0
,
Jun 9 2017
Using the per-revision bisect providing the bisect results, Good build:61.0.3118.0 (Revision:476500). Bad build:61.0.3119.0 (Revision:476838). You are probably looking for a change made after 476801 (known good), but no later than 476802 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/f985b8525943238bd43ce4e717f06613b26d284b..46d716d1d88a43617304d93d06fb587e858a2575 From the CL above, assigning the issue to the concern owner @estade: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2799003002/ Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3125.0
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53df432c9254c12868ab6c932c4c4dc486f68984 commit 53df432c9254c12868ab6c932c4c4dc486f68984 Author: Evan Stade <estade@chromium.org> Date: Mon Jun 12 17:17:17 2017 Don't show theme uninstall infobar for synced themes. Bug: 731688 Change-Id: I4c42adc0e5a11dae0486824fc7c0754413f601c8 Reviewed-on: https://chromium-review.googlesource.com/530066 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#478667} [modify] https://crrev.com/53df432c9254c12868ab6c932c4c4dc486f68984/chrome/browser/themes/theme_service.cc [modify] https://crrev.com/53df432c9254c12868ab6c932c4c4dc486f68984/chrome/browser/themes/theme_service.h [modify] https://crrev.com/53df432c9254c12868ab6c932c4c4dc486f68984/chrome/browser/themes/theme_syncable_service_unittest.cc
,
Jun 13 2017
,
Jun 19 2017
Retested this issue on Win, Mac os using chrome version 61.0.3134.0 with steps which is mentioned in comment# 0, its still reproduceable. @estade: kindly please take a look into this. Attach screen cast for the same. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rbasuvula@chromium.org
, Jun 9 2017Status: Untriaged (was: Unconfirmed)