New issue
Advanced search Search tips

Issue 731683 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

custom_deps' None issues seem to be ignored

Project Member Reported by vabr@chromium.org, Jun 9 2017

Issue description

For my checkout on a GNU/Linux machine, I have the following .gclient file:

===================
solutions = [
  { 
    "managed": False,
    "name": "src",
    "url": "https://chromium.googlesource.com/chromium/src.git",
    "custom_deps": {
      "src/third_party/adobe/flash/binaries/ppapi/linux": None,
      "src/third_party/adobe/flash/binaries/ppapi/linux_x64": None,
      "src/third_party/adobe/flash/symbols/ppapi/linux": None,
      "src/third_party/adobe/flash/symbols/ppapi/linux_x64": None,
    },
    "deps_file": ".DEPS.git",
    "safesync_url": "",
  },
  { "name"        : "src-internal",
     "url"          : <URL redacted>,
     "deps_file"    : ".DEPS.git",
  },
]
===================

When I do gclient sync, I see:

[0:08:01] Still working on:
[0:08:01]   src/third_party/adobe/flash/symbols/ppapi/linux
[0:08:01]   src/third_party/adobe/flash/symbols/ppapi/linux_x64


Expected:
The "None" value in .gclient should have prevented fetching the ppapi symbols.

Actual:
All 9+GB of the symbols seem to be downloaded.
 

Comment 1 by vabr@chromium.org, Jun 9 2017

Status: WontFix (was: Untriaged)
After looking at gclient sync -v -v -v I think I understand. It appears that the ppapi symbols were also deps for the src-internal solutions. When I copied the custom_deps in that solution, gclient sync no longer downloaded the ppapi symbols.

Sign in to add a comment