Chromium doesn't show log messages when runnig with --enable-logging on Windows |
||
Issue descriptionCurrently my branch is on commit 6471ae0edfebb65df0438736bf513028079b6cbe When I launch Chromium with --enable-logging command line flag, I don't see any log messages. Looks like it was changed in the CL https://chromium-review.googlesource.com/c/477393/ (routing code was moved from https://chromium-review.googlesource.com/c/477393/17/content/app/content_main_runner.cc to https://chromium-review.googlesource.com/c/477393/17/services/service_manager/embedder/main.cc#231) But in my build, RunServiceManager() function is never called for the main Chromium process (which is ProcessType::kEmbedder AFAIK). Due to this, log messages will not be routed to the main process STDIO. It seems that it wasn't made intentionally, so I will submit a trivial fix for this.
,
Jun 9 2017
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38d083eaea73d45388713a302faf13b93a61a120 commit 38d083eaea73d45388713a302faf13b93a61a120 Author: Andrey Kraynov <iceman@yandex-team.ru> Date: Fri Jun 09 18:34:31 2017 Route STDOUT of the main process to shell console. This will allow to see log messages when running with --enable-logging on Windows. Bug: 731672 Change-Id: Ifea1498427cc510abe459664a693a71601368356 Reviewed-on: https://chromium-review.googlesource.com/528086 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#478345} [modify] https://crrev.com/38d083eaea73d45388713a302faf13b93a61a120/services/service_manager/embedder/main.cc
,
Jun 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 Deleted