New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731657 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.5%-26.7% regression in blink_perf.css at 477288:477510

Project Member Reported by primiano@chromium.org, Jun 9 2017

Issue description

See the link to graphs below.
 
Cc: fs...@chromium.org
Owner: fs...@chromium.org

=== Auto-CCing suspected CL author fserb@chromium.org ===

Hi fserb@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Fernando Serboncini
  Commit : 2e48d743c9c647a66409c98ba96cbe80fd70774b
  Date   : Tue Jun 06 19:49:57 2017
  Subject: Remove CSSTextCache from CSSPrimitiveValue

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : blink_perf.css
  Metric       : CSSPropertySetterGetter/CSSPropertySetterGetter
  Change       : 4.87% | 375.182832747 -> 356.90500877

Revision             Result                  N
chromium@477371      375.183 +- 10.4449      6      good
chromium@477376      369.697 +- 9.81595      6      good
chromium@477378      370.099 +- 4.91142      6      good
chromium@477379      365.164 +- 14.4971      6      good
chromium@477380      348.32 +- 14.4112       6      bad       <--
chromium@477389      350.299 +- 12.5699      6      bad
chromium@477406      345.111 +- 8.87729      6      bad
chromium@477441      343.011 +- 7.64996      6      bad
chromium@477510      356.905 +- 10.1645      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.css

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977268071149550960

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5807709049323520


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
 Issue 731656  has been merged into this issue.
 Issue 731661  has been merged into this issue.

Comment 6 by fs...@chromium.org, Jun 9 2017

Soooo.

Yesterday I submited https://chromium-review.googlesource.com/527212 which should bring the speed sligthly back up.

That said, I think the tests are very misleading, since they are all hot-cache tests. I'll propose a change to it soon.

Comment 7 by fs...@chromium.org, Jun 9 2017

Status: WontFix (was: Untriaged)
If anyone wants to discuss this further, just reopen the bug.
Labels: Performance-Tradeoff
We have cold cache tests, too. FYI.

Comment 9 by nainar@chromium.org, Aug 18 2017

Cc: maxlg@chromium.org shend@chromium.org dtapu...@chromium.org alexclarke@chromium.org nainar@chromium.org
 Issue 732307  has been merged into this issue.

Sign in to add a comment