New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731647 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.5% regression in system_health.memory_mobile at 476400:476563

Project Member Reported by primiano@chromium.org, Jun 9 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=731647

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgltCtyggM


Bot(s) for this bug's original alert(s):

android-nexus5X
Cc: timbrown@chromium.org
Owner: timbrown@chromium.org

=== Auto-CCing suspected CL author timbrown@chromium.org ===

Hi timbrown@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : timbrown
  Commit : 3612567b1d18726aa2acc3b477c615f98c016c0a
  Date   : Thu Jun 01 23:20:15 2017
  Subject: Unify if guards of GetLinuxWindowManager.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:java_heap:effective_size_avg/browse_news/browse_news_reddit
  Change       : 0.12% | 65633325.3333 -> 65714699.0

Revision             Result                   N
chromium@476399      65633325 +- 16250.3      6      good
chromium@476440      65508395 +- 260700       9      good
chromium@476461      65403381 +- 130043       6      good
chromium@476471      65376250 +- 11296.0      6      good
chromium@476476      65428086 +- 54212.1      6      good
chromium@476479      65478072 +- 78659.5      6      good
chromium@476480      65475010 +- 114644       6      good
chromium@476481      65758134 +- 179565       6      bad       <--
chromium@476563      65714699 +- 62774.2      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.reddit system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977268495733395632

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6702951394967552


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: primiano@chromium.org
My change would be a nop for Android:

#if defined(USE_X11) && !defined(OS_CHROMEOS)

changed to:

#if defined(OS_LINUX) && defined(USE_X11) && !defined(OS_CHROMEOS)

@primiano: not sure what to do with this bug, so assigning to you.
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Owner: ----
Status: Available (was: Assigned)
Just read the attached doc and saw I need to unassign the bug. I'll also kick off a new bisect.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jul 27 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:java_heap:effective_size_avg/browse_news/browse_news_reddit

Revision             Result                  N
chromium@476399      64970582 +- 362076      21      good
chromium@476563      64913954 +- 517368      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.reddit system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8972881658654102976


For feedback, file a bug with component Speed>Bisection
I'm not sure how real this is, the ref moved a bit too.  I kicked off a couple of wider bisects - lets see what they find.
Status: WontFix (was: Available)
WontFix-ing because the ref build moved too and the second bisect couldn't repro.

Sign in to add a comment