Issue metadata
Sign in to add a comment
|
[HiDPI] No blinking cursor visible in the comment box
Reported by
sbo...@opera.com,
Jun 9 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3107.4 Safari/537.36 OPR/47.0.2619.0 (Edition developer) Steps to reproduce the problem: 1. Run browser with switch --force-device-scale-factor=0.9 2. Go to http://blogs.opera.com/desktop/2017/06/opera-beta-46-0-2597-14-update/ 3. Try to write some comment What is the expected behavior? Blinking cursor is visible in the comment box What went wrong? No blinking cursor visible in the comment box Did this work before? N/A Chrome version: 60.0.3107.4 Channel: dev OS Version: 10.0 Flash Version: Shockwave Flash 25.0 r0
,
Jun 23 2017
Able to reproduce the issue on Windows 10 using chrome reported version #60.0.3107.4 and latest canary #61.0.3138.0. Issue not seen in OS-Mac and OS-Linux. Bisect Information: ===================== Good build: 58.0.3011.0 Revision(449903) Bad Build : 58.0.3012.0 Revision(450199) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/549d1501a66ed2ec0283149f65c71d64569183aa..3353063df1bbda55628a8c1e0a0d1f1289d80b78 From the above change log suspecting below change Review url: https://codereview.chromium.org/2683233005 malaykeshav@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks...!!
,
Aug 9 2017
,
Oct 25 2017
Route to Blink>Paint
,
Oct 25 2017
This is a straightforward fix to ensure a min caret width of 1.
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3 commit f46b7b6ef94461ac0cc4247bbd829576ed8c89b3 Author: Stephen Chenney <schenney@chromium.org> Date: Fri Oct 27 21:07:34 2017 Force caret painting at low DPI The caret width must be forced non-zero when the DPI is lower than 1. Widths less than 1 do not paint. R=pdr@chromium.org BUG= 731643 Change-Id: I05953a3a029253644e801058d83988b4822418ba Reviewed-on: https://chromium-review.googlesource.com/740063 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#512280} [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/editing/caret/caret-painting-low-dpi.html [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-painting-low-dpi-expected.png [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/caret/caret-painting-low-dpi-expected.png [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/caret/caret-painting-low-dpi-expected.txt [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/caret/caret-painting-low-dpi-expected.png [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/platform/mac-retina/editing/caret/caret-painting-low-dpi-expected.png [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-painting-low-dpi-expected.png [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-painting-low-dpi-expected.txt [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-painting-low-dpi-expected.png [add] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-painting-low-dpi-expected.txt [modify] https://crrev.com/f46b7b6ef94461ac0cc4247bbd829576ed8c89b3/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
,
Oct 30 2017
I don't think it's worth merging this. To my knowledge DPI below 1 is not common. . |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Jun 19 2017