New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731636 link

Starred by 1 user
Status: Archived
Owner:
█ youcheng@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
█ youcheng@chromium.org
hungte@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

factory: DeviceBoard.ReadSpecialFile might fail on some special files

Project Member Reported by youcheng@chromium.org, Jun 9 2017 
branch: ToT

Currently DeviceBoard.ReadSpecialFile calls file.seek when using local link,
but this might fail for some special files under sysfs (e.g., /sys/kernel/debug/atmel_mxt_ts/*/refs),
and raise an exception "IOError: [Error 29] Illegal seek".

We should revise ReadSpecialFile and make it able to handle this kind of files.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/a8f691dde583199c116cb90508e534d19881e63c

commit a8f691dde583199c116cb90508e534d19881e63c
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Fri Jun 09 16:16:28 2017

device: board: Fix ReadSpecialFile.

Performing 'seek' operation on file objects of special file might raise
an exception IOError ([Error 29] Illegal seek). We could fallback to
'read' and then discard the result to resolve this issue.

BUG= chromium:731636 
TEST=manually

Change-Id: I58f6a303fda7b274f577e98e85ee18bb09d854e6
Reviewed-on: https://chromium-review.googlesource.com/527981
Commit-Ready: Youcheng Syu <youcheng@chromium.org>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/a8f691dde583199c116cb90508e534d19881e63c/py/device/board.py

Comment 2 by youcheng@chromium.org, Jun 12 2017

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment