New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731600 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Print Preview Page Selection

Reported by frayz...@gmail.com, Jun 9 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.24 Safari/537.36

Steps to reproduce the problem:
1. Print Preview a multi-page document
2. Select another page other than 1 (it will show the 1st page regardless)
3. Put it back to ALL (all other pages will now be blank)

See video.
https://www.youtube.com/watch?v=6JRzzqStq30&feature=youtu.be

What is the expected behavior?

What went wrong?
See reproduction steps.

Did this work before? Yes 59.0.3071.86

Chrome version: 60.0.3112.24  Channel: beta
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
2017-06-09_09-53-20.mp4
9.8 MB View Download
Cc: thestig@chromium.org pbomm...@chromium.org ligim...@chromium.org
Components: -UI UI>Browser>PrintPreview
Labels: M-60 ReleaseBlock-Stable OS-Linux OS-Mac
Status: Available (was: Unconfirmed)
Able to reproduce the issue with latest Chrome beta(60.0.3112.24) and canary(61.0.3124.10) on Windows 7,10, Mac and Linux

Comment 2 by pdr@chromium.org, Jun 11 2017

Labels: Needs-Bisect
I just hit this as well. Could someone bisect to see when this regressed?
Labels: -Pri-2 -Needs-Bisect hasbisect Pri-1
Owner: thestig@chromium.org
Status: Assigned (was: Available)
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.5 using reported version #60.0.3112.24 and latest canary #61.0.3127.0.

Bisect Information:
=====================
Good build: 60.0.3090.0	 Revision(469538)
Bad Build : 60.0.3091.0	 Revision(469814)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/9a07822e01e3e572b016b9b6434936a7284b04af..8f6f9c1597928d3df4cd6a44942c323ef8e46fee

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2833993004

thestig@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Unable to provide bisect using new script for the above revision range. Hence, providing the bisect using old script.

Thanks...!!
Able to reproduce the issue on windows 7 using chrome version 60.0.3112.24.
thestig@ Please look into this as it is marked as stable blocker.

Thanks,
Hi guys, 

If that's of any use: if the "blanked" preview is printed, you end up with 1st page followed by blank pages

Regards
Cc: rbasuvula@chromium.org
Still able to reproduce the issue on Win 7 using latest chrome version 61.0.3136.0

thestig@ Please look into this as it is marked as stable blocker.

Thanks,
Still able to reproduce the issue on Win 7 using latest chrome version 61.0.3141.0

thestig@ Please look into this as it is marked as stable blocker.

Thanks,
 Issue 737028  has been merged into this issue.
Gentle ping! Still able to reproduce the issue on Win 7 using latest chrome version 61.0.3148.0

thestig@ Please look into this as it is marked as stable blocker.

Thanks,
Hi, 

Reading the diff, I think, that a call to `hasPreviewPageRangeChanged_`is missing in `hasPreviewChanged_`:

     /**
-     * @return {boolean} Whether the print ticket has changed sufficiently to
-     *     determine whether a new preview request should be issued.
+     * @return {boolean} Whether the print ticket, excluding the page range, has
+     *     changed sufficiently to determine whether a new preview request
+     *     should be issued.
      * @private
      */
     hasPreviewChanged_: function() {
@@ -286,9 +298,6 @@
           !ticketStore.color.isValueEqual(this.colorValue_) ||
           !ticketStore.scaling.isValueEqual(this.scalingValue_) ||
           !ticketStore.fitToPage.isValueEqual(this.isFitToPageEnabled_) ||
-          this.pageRanges_ == null ||
-          !areRangesEqual(ticketStore.pageRange.getPageRanges(),
-                          this.pageRanges_) ||
           (!ticketStore.marginsType.isValueEqual(this.marginsType_) &&
               !ticketStore.marginsType.isValueEqual(
                   print_preview.ticket_items.MarginsTypeValue.CUSTOM)) ||
@@ -305,6 +314,17 @@
     },
 
     /**
+     * @return {boolean} Whether the page range in the print ticket has changed.
+     * @private
+     */
+    hasPreviewPageRangeChanged_: function() {
+      return this.pageRanges_ == null ||
+          !areRangesEqual(
+              this.printTicketStore_.pageRange.getPageRanges(),
+              this.pageRanges_);
+    },
+
+    /**

If in print preview I change the orientation, the bug is fixed (because it triggers `hasPreviewChanged_`I think). Verified with Chrome 60.0.3112.32 (Build officiel) beta (64 bits)

I hope that helps.
Cc: msrchandra@chromium.org ranjitkan@chromium.org nyerramilli@chromium.org
 Issue 739684  has been merged into this issue.
Just to update the latest behavior,
Still able to reproduce the issue on Win-10 using latest canary #61.0.3155.0.

thestig@ - Gentle Ping...!!
Could you please have a look into the issue as it has been marked as a stable blocker.

Thanks...!!
I chatted with thestig@ and he'll be able to look at it this week.

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34e22410141c1c4d3c7efe5ee821b09d837bf995

commit 34e22410141c1c4d3c7efe5ee821b09d837bf995
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Jul 20 04:05:10 2017

Print Preview: Disable Generate Draft feature.

The attempt to restore this feature in r469749 did not quite do the job
and has several issues.

BUG= 731600 , 740830 , 746768 

Change-Id: I417611e32e6d3e1bb29c96f6e5de6eee39abc846
Reviewed-on: https://chromium-review.googlesource.com/577374
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488129}
[modify] https://crrev.com/34e22410141c1c4d3c7efe5ee821b09d837bf995/chrome/browser/resources/print_preview/preview_generator.js
[modify] https://crrev.com/34e22410141c1c4d3c7efe5ee821b09d837bf995/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js

Status: Fixed (was: Assigned)
Will request M60 merge soon.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Approved-60
This change meets the bar and is approved for merge into M60 (build 3112)
Cc: bustamante@chromium.org gov...@chromium.org ajha@chromium.org manoranj...@chromium.org
 Issue 746940  has been merged into this issue.
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 21 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d02baa474b267c2b53ac85a6faa3279310163f30

commit d02baa474b267c2b53ac85a6faa3279310163f30
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Jul 21 22:40:18 2017

M60: Print Preview: Disable Generate Draft feature.

The attempt to restore this feature in r469749 did not quite do the job
and has several issues.

This is not cherry-picked from the master branch because the related
test got rewritten.

BUG= 731600 , 740830 , 746768 

Cr-Original-Original-Commit-Position: refs/heads/master@{#488129}
Reviewed-on: https://chromium-review.googlesource.com/577374
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8c7ec7bb50c390ad6aef603885f41cb46f8d05e2
Reviewed-on: https://chromium-review.googlesource.com/581676
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#662}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/d02baa474b267c2b53ac85a6faa3279310163f30/chrome/browser/resources/print_preview/preview_generator.js
[modify] https://crrev.com/d02baa474b267c2b53ac85a6faa3279310163f30/chrome/test/data/webui/print_preview/print_preview.js

Sign in to add a comment