Print Preview Page Selection
Reported by
frayz...@gmail.com,
Jun 9 2017
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.24 Safari/537.36 Steps to reproduce the problem: 1. Print Preview a multi-page document 2. Select another page other than 1 (it will show the 1st page regardless) 3. Put it back to ALL (all other pages will now be blank) See video. https://www.youtube.com/watch?v=6JRzzqStq30&feature=youtu.be What is the expected behavior? What went wrong? See reproduction steps. Did this work before? Yes 59.0.3071.86 Chrome version: 60.0.3112.24 Channel: beta OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Jun 11 2017
I just hit this as well. Could someone bisect to see when this regressed?
,
Jun 12 2017
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.5 using reported version #60.0.3112.24 and latest canary #61.0.3127.0. Bisect Information: ===================== Good build: 60.0.3090.0 Revision(469538) Bad Build : 60.0.3091.0 Revision(469814) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/9a07822e01e3e572b016b9b6434936a7284b04af..8f6f9c1597928d3df4cd6a44942c323ef8e46fee From the above change log suspecting below change Review URL: https://codereview.chromium.org/2833993004 thestig@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Unable to provide bisect using new script for the above revision range. Hence, providing the bisect using old script. Thanks...!!
,
Jun 15 2017
Able to reproduce the issue on windows 7 using chrome version 60.0.3112.24. thestig@ Please look into this as it is marked as stable blocker. Thanks,
,
Jun 16 2017
Hi guys, If that's of any use: if the "blanked" preview is printed, you end up with 1st page followed by blank pages Regards
,
Jun 21 2017
Still able to reproduce the issue on Win 7 using latest chrome version 61.0.3136.0 thestig@ Please look into this as it is marked as stable blocker. Thanks,
,
Jun 27 2017
Still able to reproduce the issue on Win 7 using latest chrome version 61.0.3141.0 thestig@ Please look into this as it is marked as stable blocker. Thanks,
,
Jun 27 2017
Issue 737028 has been merged into this issue.
,
Jul 4 2017
Gentle ping! Still able to reproduce the issue on Win 7 using latest chrome version 61.0.3148.0 thestig@ Please look into this as it is marked as stable blocker. Thanks,
,
Jul 4 2017
Hi,
Reading the diff, I think, that a call to `hasPreviewPageRangeChanged_`is missing in `hasPreviewChanged_`:
/**
- * @return {boolean} Whether the print ticket has changed sufficiently to
- * determine whether a new preview request should be issued.
+ * @return {boolean} Whether the print ticket, excluding the page range, has
+ * changed sufficiently to determine whether a new preview request
+ * should be issued.
* @private
*/
hasPreviewChanged_: function() {
@@ -286,9 +298,6 @@
!ticketStore.color.isValueEqual(this.colorValue_) ||
!ticketStore.scaling.isValueEqual(this.scalingValue_) ||
!ticketStore.fitToPage.isValueEqual(this.isFitToPageEnabled_) ||
- this.pageRanges_ == null ||
- !areRangesEqual(ticketStore.pageRange.getPageRanges(),
- this.pageRanges_) ||
(!ticketStore.marginsType.isValueEqual(this.marginsType_) &&
!ticketStore.marginsType.isValueEqual(
print_preview.ticket_items.MarginsTypeValue.CUSTOM)) ||
@@ -305,6 +314,17 @@
},
/**
+ * @return {boolean} Whether the page range in the print ticket has changed.
+ * @private
+ */
+ hasPreviewPageRangeChanged_: function() {
+ return this.pageRanges_ == null ||
+ !areRangesEqual(
+ this.printTicketStore_.pageRange.getPageRanges(),
+ this.pageRanges_);
+ },
+
+ /**
If in print preview I change the orientation, the bug is fixed (because it triggers `hasPreviewChanged_`I think). Verified with Chrome 60.0.3112.32 (Build officiel) beta (64 bits)
I hope that helps.
,
Jul 6 2017
Issue 739684 has been merged into this issue.
,
Jul 12 2017
Just to update the latest behavior, Still able to reproduce the issue on Win-10 using latest canary #61.0.3155.0. thestig@ - Gentle Ping...!! Could you please have a look into the issue as it has been marked as a stable blocker. Thanks...!!
,
Jul 17 2017
I chatted with thestig@ and he'll be able to look at it this week.
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34e22410141c1c4d3c7efe5ee821b09d837bf995 commit 34e22410141c1c4d3c7efe5ee821b09d837bf995 Author: Lei Zhang <thestig@chromium.org> Date: Thu Jul 20 04:05:10 2017 Print Preview: Disable Generate Draft feature. The attempt to restore this feature in r469749 did not quite do the job and has several issues. BUG= 731600 , 740830 , 746768 Change-Id: I417611e32e6d3e1bb29c96f6e5de6eee39abc846 Reviewed-on: https://chromium-review.googlesource.com/577374 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#488129} [modify] https://crrev.com/34e22410141c1c4d3c7efe5ee821b09d837bf995/chrome/browser/resources/print_preview/preview_generator.js [modify] https://crrev.com/34e22410141c1c4d3c7efe5ee821b09d837bf995/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
,
Jul 20 2017
Will request M60 merge soon.
,
Jul 20 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 21 2017
This change meets the bar and is approved for merge into M60 (build 3112)
,
Jul 21 2017
Issue 746940 has been merged into this issue.
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d02baa474b267c2b53ac85a6faa3279310163f30 commit d02baa474b267c2b53ac85a6faa3279310163f30 Author: Lei Zhang <thestig@chromium.org> Date: Fri Jul 21 22:40:18 2017 M60: Print Preview: Disable Generate Draft feature. The attempt to restore this feature in r469749 did not quite do the job and has several issues. This is not cherry-picked from the master branch because the related test got rewritten. BUG= 731600 , 740830 , 746768 Cr-Original-Original-Commit-Position: refs/heads/master@{#488129} Reviewed-on: https://chromium-review.googlesource.com/577374 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8c7ec7bb50c390ad6aef603885f41cb46f8d05e2 Reviewed-on: https://chromium-review.googlesource.com/581676 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#662} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/d02baa474b267c2b53ac85a6faa3279310163f30/chrome/browser/resources/print_preview/preview_generator.js [modify] https://crrev.com/d02baa474b267c2b53ac85a6faa3279310163f30/chrome/test/data/webui/print_preview/print_preview.js |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by pbomm...@chromium.org
, Jun 9 2017Components: -UI UI>Browser>PrintPreview
Labels: M-60 ReleaseBlock-Stable OS-Linux OS-Mac
Status: Available (was: Unconfirmed)