Issue metadata
Sign in to add a comment
|
Regression:Unwanted scrollbar appears in print preview page |
||||||||||||||||||||||
Issue descriptionChrome Version:61.0.3124.0/9632.0.0 dev channel Peppy,Kip and Paine OS:Chrome What steps will reproduce the problem? (1)Sign in to user->Launch chrome and Press Ctrl+P for Print preview (2)Click on More settings link and Observe(kindly refer video) Actual:Unwanted scrollbar appears in More settings Expected:No such unwanted scrollbar should be seen This is a Regression issue as same is working fine in 59.0.3071.0/9460.60.0 beta channel Paine Note: 1.Able to reproduce issue in 60.0.3112.20/9592.11.0 dev 2.Issue is not seen in Windows,Linux OS
,
Jun 14 2017
I tried 59.0.3071.0 locally on my workstation, not on a device. Even there a scrollbar still appears.
,
Jun 14 2017
It looks like the "print using system dialog" <div> is just using up space. Even though it has a height of 0, it has non-zero padding. skau: Just to double check - we are not using "print using system dialog" on ChromeOS at all, right? Maybe we can just omit it on ChromeOS? The issue isn't that severe. Let's downgrade to P2.
,
Jun 14 2017
We don't use "Print Using System Dialog" in ChromeOS. It's safe to remove.
,
Jun 16 2017
,
Jun 23 2017
,
Jul 10 2017
I dunno why this was assigned to me (connection to scrollbar?). Demetrios, who owns print preview these days?
,
Jul 10 2017
@rbpotter: Can you take a look?
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58eaa08bb7b92a9c3b9a826fc4126e1660286e8e commit 58eaa08bb7b92a9c3b9a826fc4126e1660286e8e Author: rbpotter <rbpotter@chromium.org> Date: Wed Jul 12 02:06:21 2017 Print Preview: Remove system dialog link container on ChromeOS Should not add the link-container on ChromeOS as the system dialog link will never be shown. BUG= 731578 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2979743002 Cr-Commit-Position: refs/heads/master@{#485794} [modify] https://crrev.com/58eaa08bb7b92a9c3b9a826fc4126e1660286e8e/chrome/browser/resources/print_preview/print_preview.html
,
Jul 26 2017
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by thestig@chromium.org
, Jun 13 2017