cryptohome: Possible dead lock in MigrationHelper when all job threads fail |
|||||||
Issue descriptionAs dspaid@ pointed out, MigrationHelper::WorkerPool::PushJob() can block forever when all job threads stop working because of errors. https://chromium-review.googlesource.com/c/520823/4/cryptohome/dircrypto_data_migrator/migration_helper.cc#212
,
Jun 14 2017
,
Jun 14 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 19 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6cf4ce99eee0be2bb0f9ce9021e419bac30e3e54 commit 6cf4ce99eee0be2bb0f9ce9021e419bac30e3e54 Author: Ryo Hashimoto <hashimoto@google.com> Date: Thu Jun 22 06:27:31 2017 cryptohome: Abort job processing when error occurs during migration Dircrypto migration can deadlock when all job threads stop due to errors. Add Abort() method to MigrationHelper::WorkerPool. BUG= chromium:731575 TEST=cros_workon_make --test cryptohome Change-Id: Idd4bc821777a844e1c6ab6a88aef41f2011031fc Previous-Reviewed-on: https://chromium-review.googlesource.com/527782 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> (cherry picked from commit 4d72604c6f0fe0cf80441bfa721ddc9cb7055dd0) Reviewed-on: https://chromium-review.googlesource.com/544477 Trybot-Ready: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/6cf4ce99eee0be2bb0f9ce9021e419bac30e3e54/cryptohome/dircrypto_data_migrator/migration_helper.cc [modify] https://crrev.com/6cf4ce99eee0be2bb0f9ce9021e419bac30e3e54/cryptohome/dircrypto_data_migrator/migration_helper_unittest.cc
,
Jun 22 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 9 2017