New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731575 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 688900



Sign in to add a comment

cryptohome: Possible dead lock in MigrationHelper when all job threads fail

Project Member Reported by hashimoto@chromium.org, Jun 9 2017

Issue description

As dspaid@ pointed out, MigrationHelper::WorkerPool::PushJob() can block forever when all job threads stop working because of errors.
https://chromium-review.googlesource.com/c/520823/4/cryptohome/dircrypto_data_migrator/migration_helper.cc#212
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4d72604c6f0fe0cf80441bfa721ddc9cb7055dd0

commit 4d72604c6f0fe0cf80441bfa721ddc9cb7055dd0
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Fri Jun 09 14:10:42 2017

cryptohome: Abort job processing when error occurs during migration

Dircrypto migration can deadlock when all job threads stop due to
errors.
Add Abort() method to MigrationHelper::WorkerPool.

BUG= chromium:731575 
TEST=cros_workon_make --test cryptohome

Change-Id: Idd4bc821777a844e1c6ab6a88aef41f2011031fc
Reviewed-on: https://chromium-review.googlesource.com/527782
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[modify] https://crrev.com/4d72604c6f0fe0cf80441bfa721ddc9cb7055dd0/cryptohome/dircrypto_data_migrator/migration_helper.cc
[modify] https://crrev.com/4d72604c6f0fe0cf80441bfa721ddc9cb7055dd0/cryptohome/dircrypto_data_migrator/migration_helper_unittest.cc

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 14 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/6cf4ce99eee0be2bb0f9ce9021e419bac30e3e54

commit 6cf4ce99eee0be2bb0f9ce9021e419bac30e3e54
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Thu Jun 22 06:27:31 2017

cryptohome: Abort job processing when error occurs during migration

Dircrypto migration can deadlock when all job threads stop due to
errors.
Add Abort() method to MigrationHelper::WorkerPool.

BUG= chromium:731575 
TEST=cros_workon_make --test cryptohome

Change-Id: Idd4bc821777a844e1c6ab6a88aef41f2011031fc
Previous-Reviewed-on: https://chromium-review.googlesource.com/527782
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
(cherry picked from commit 4d72604c6f0fe0cf80441bfa721ddc9cb7055dd0)
Reviewed-on: https://chromium-review.googlesource.com/544477
Trybot-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>

[modify] https://crrev.com/6cf4ce99eee0be2bb0f9ce9021e419bac30e3e54/cryptohome/dircrypto_data_migrator/migration_helper.cc
[modify] https://crrev.com/6cf4ce99eee0be2bb0f9ce9021e419bac30e3e54/cryptohome/dircrypto_data_migrator/migration_helper_unittest.cc

Labels: -Hotlist-Merge-Review -Merge-Approved-60
Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment