Milo's build_test.go fails when the local timezone is not -07:00 |
|||
Issue description
Example difference between expectation and actual output:
diff -u expected actual
--- expected 2017-06-09 16:31:14.828702692 +1000
+++ actual 2017-06-09 16:31:37.540630563 +1000
@@ -689,7 +689,7 @@
{
"AuthorName": "",
"AuthorEmail": "moshayedi@chromium.org",
- "CommitTime": "2016-06-08T13:23:28-07:00",
+ "CommitTime": "2016-06-09T06:23:28+10:00",
"Repo": "https://chromium.googlesource.com/chromium/src",
"Branch": "",
"RequestRevision": null,
@@ -731,7 +731,7 @@
{
"AuthorName": "",
"AuthorEmail": "fsamuel@chromium.org",
- "CommitTime": "2016-06-08T13:25:32-07:00",
+ "CommitTime": "2016-06-09T06:25:32+10:00",
"Repo": "https://chromium.googlesource.com/chromium/src",
"Branch": "",
"RequestRevision": null,
@@ -754,7 +754,7 @@
{
"AuthorName": "",
"AuthorEmail": "gab@chromium.org",
- "CommitTime": "2016-06-08T13:25:33-07:00",
+ "CommitTime": "2016-06-09T06:25:33+10:00",
"Repo": "https://chromium.googlesource.com/chromium/src",
"Branch": "",
"RequestRevision": null,
@@ -778,7 +778,7 @@
{
"AuthorName": "",
"AuthorEmail": "dtseng@chromium.org",
- "CommitTime": "2016-06-08T13:27:19-07:00",
+ "CommitTime": "2016-06-09T06:27:19+10:00",
"Repo": "https://chromium.googlesource.com/chromium/src",
"Branch": "",
"RequestRevision": null,
@@ -801,7 +801,7 @@
{
"AuthorName": "",
"AuthorEmail": "yolandyan@google.com",
- "CommitTime": "2016-06-08T13:30:29-07:00",
+ "CommitTime": "2016-06-09T06:30:29+10:00",
"Repo": "https://chromium.googlesource.com/chromium/src",
"Branch": "",
"RequestRevision": null,
@@ -823,7 +823,7 @@
{
"AuthorName": "",
"AuthorEmail": "dcheng@chromium.org",
- "CommitTime": "2016-06-08T13:32:34-07:00",
+ "CommitTime": "2016-06-09T06:32:34+10:00",
"Repo": "https://chromium.googlesource.com/chromium/src",
"Branch": "",
"RequestRevision": null,
@@ -880,7 +880,7 @@
{
"AuthorName": "",
"AuthorEmail": "agrieve@chromium.org",
- "CommitTime": "2016-06-08T13:32:35-07:00",
+ "CommitTime": "2016-06-09T06:32:35+10:00",
"Repo": "https://chromium.googlesource.com/chromium/src",
"Branch": "",
"RequestRevision": null,
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/61e8b0d41951da9c4833c8b597c8f07e129b625b commit 61e8b0d41951da9c4833c8b597c8f07e129b625b Author: dsansome <dsansome@chromium.org> Date: Fri Jun 09 06:49:58 2017 Disable broken Milo tests. BUG= 731562 TBR=hinoka Review-Url: https://codereview.chromium.org/2926263003 [modify] https://crrev.com/61e8b0d41951da9c4833c8b597c8f07e129b625b/milo/appengine/buildbot/build_test.go [modify] https://crrev.com/61e8b0d41951da9c4833c8b597c8f07e129b625b/milo/appengine/frontend/main_test.go
,
Jun 9 2017
These timestamps are supposed to all be UTC
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/84cdc840d95d717483da83075f99336df4c03e39 commit 84cdc840d95d717483da83075f99336df4c03e39 Author: hinoka <hinoka@google.com> Date: Fri Jun 09 19:12:09 2017 Milo: Use UTC representation for commit time in blamelist This also reverts https://codereview.chromium.org/2926263003/ BUG= 731562 Review-Url: https://codereview.chromium.org/2929173002 [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/buildbot/build.go [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/buildbot/build_test.go [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/buildbot/builder.go [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/buildbot/expectations/CrWinGoma.30608.build.json [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/buildbot/expectations/chromium_presubmit.426944.build.json [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/buildbot/expectations/win_chromium_rel_ng.246309.build.json [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html [modify] https://crrev.com/84cdc840d95d717483da83075f99336df4c03e39/milo/appengine/frontend/main_test.go
,
Jun 12 2017
This should be fixed
,
Jun 13 2017
Thanks for the quick fix! |
|||
►
Sign in to add a comment |
|||
Comment 1 by dsansome@chromium.org
, Jun 9 2017Same with the frontend's main_test.go: --- expected2 2017-06-09 16:38:32.775309536 +1000 +++ actual2 2017-06-09 16:38:28.035324606 +1000 @@ -1059,7 +1059,7 @@ </tr> <tr> <td class="left">Changed at</td> - <td class="value"><span class="local-time" data-timestamp="1467070229000">Monday, 27-Jun-16 16:30:29 PDT</span></td> + <td class="value"><span class="local-time" data-timestamp="1467070229000">Tuesday, 28-Jun-16 09:30:29 AEST</span></td> </tr> <tr> <td class="left">Repository</td> @@ -1148,4 +1148,4 @@ ga('send', 'pageview'); </script>