[MD Bookmarks] Open in new tab/window keyboard shortcuts don't trigger on Mac |
||
Issue descriptionOn a Mac: 1. Navigate to MD Bookmarks 2. Select a single item 3. Press shift-enter Expected behavior: Item opens in new window Actual behavior: Edit dialog opens for that item This happens because the keyboard shortcut for 'Enter' is registered before the shortcut for 'Shift+Enter'. iron-a11y-keys allows an event for 'Shift+Enter' to trigger a shortcut for 'Enter', which causes the Edit command to trigger instead of the Open command.
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0292e51a152b3209d4aa203c265a513bf75bc321 commit 0292e51a152b3209d4aa203c265a513bf75bc321 Author: tsergeant <tsergeant@chromium.org> Date: Fri Jun 16 03:44:35 2017 MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly MD Bookmarks did not correctly distinguish between a keypress of 'Enter' vs 'Shift-Enter', meaning that someone trying to 'Open in new window' could instead 'Edit' or 'Open', depending on platform. This fixes the issue by moving shortcut handling from iron-a11y-keys to using the standard WebUI Command handlers. BUG= 731531 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2939873004 Cr-Commit-Position: refs/heads/master@{#479940} [modify] https://crrev.com/0292e51a152b3209d4aa203c265a513bf75bc321/chrome/browser/resources/md_bookmarks/command_manager.html [modify] https://crrev.com/0292e51a152b3209d4aa203c265a513bf75bc321/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/0292e51a152b3209d4aa203c265a513bf75bc321/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [modify] https://crrev.com/0292e51a152b3209d4aa203c265a513bf75bc321/chrome/test/data/webui/md_bookmarks/command_manager_test.js [modify] https://crrev.com/0292e51a152b3209d4aa203c265a513bf75bc321/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js [modify] https://crrev.com/0292e51a152b3209d4aa203c265a513bf75bc321/ui/webui/resources/js/cr/ui/command.js
,
Jun 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by tsergeant@chromium.org
, Jun 14 2017